Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revamp proposal for the nutrition table #3136

Open
g123k opened this issue Oct 13, 2022 · 7 comments
Open

Revamp proposal for the nutrition table #3136

g123k opened this issue Oct 13, 2022 · 7 comments

Comments

@g123k
Copy link
Collaborator

g123k commented Oct 13, 2022

What

  • Hi everyone,

  • While working on the product edition, I thought about some enhancements for the nutrition table/facts.
    I have identified 5 issues:

  • The switch for “no nutrition fact” seems inverted (on the left?)

  • The question is negative
  • The serving unit is at the center of the screen without being really understandable for newcomers
  • It’s difficult to understand that we can change the unit
  • We can't select ranges (<, >, ~…)

Hence, my proposal:

Feel free to share your comments :)

Part of

@monsieurtanuki
Copy link
Contributor

@g123k Your suggestion looks great!

My remarks:

  1. as you know off-dart does not support < > for the moment, so that column is not relevant (yet)
  2. the units take too much space for little added value - given the low frequency when a user changes the unit, we would be better off with only one unit and a button
  3. in a near future, we'll have to handle not only "product as sold" data (the standard nutrition table), but also "product as prepared" (e.g. for cocoa powder when mixed with milk), cf. Nutrition edit - If i switch to serving, it removes all values, except the energy in kcal #3046, and it would be great if you could take that into consideration in your design
  4. there's no "save" button in your screen - I think it should always be visible

@teolemon
Copy link
Member

What happens on narrow screens, and with prepared scrolling ? Does it scroll sideways ?

@teolemon
Copy link
Member

Also personal opinion: the table looks intimidating. Very precise, but a bit intimidating (I'm going to break something)

@VaiTon
Copy link
Member

VaiTon commented Oct 13, 2022

I really like the table design. It's clear and resembles the one on the packaging.

there's no "save" button in your screen - I think it should always be visible

The save button could be put as an action button on the appbar!

For the rest, I'm with @monsieurtanuki

@monsieurtanuki
Copy link
Contributor

@g123k Btw I'm currently refactoring the nutriment page: nothing about the display, but as an impact of openfoodfacts/openfoodfacts-dart#570

@galnaf
Copy link

galnaf commented Oct 27, 2022

What if the serving size is not 100 gr. Would there be a way to enter it manually?

@g123k
Copy link
Collaborator Author

g123k commented Oct 27, 2022

What if the serving size is not 100 gr. Would there be a way to enter it manually?

Yes, that the "serving size" field

@teolemon teolemon changed the title [Nutrition table] A suggestion Revamp proposal for the nutrition table Dec 10, 2022
@teolemon teolemon removed the ✨ enhancement New feature or request label Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 💬 To discuss and validate
Development

No branches or pull requests

5 participants