Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the ability to take/see/edit the nutrition photo in the ingredients input #3772

Closed
teolemon opened this issue Mar 16, 2023 · 4 comments · Fixed by #3851
Closed

Add the ability to take/see/edit the nutrition photo in the ingredients input #3772

teolemon opened this issue Mar 16, 2023 · 4 comments · Fixed by #3851

Comments

@teolemon
Copy link
Member

What

  • Add the ability to take/see/edit the nutrition photo in the ingredients input
    image

Part of

@monsieurtanuki
Copy link
Contributor

@teolemon Please be more specific, UI/UX wise. There are already many fields to populate on that screen, and displaying a photo on top may make it a bit confusing.

@teolemon
Copy link
Member Author

teolemon commented Mar 17, 2023

@monsieurtanuki The last mockup I did is this one, with a vertical split screen, and the ability to slide each part. It probably does not work on smaller screens, so we could go for something smaller (a button, and an expandable miniature photo ?)

@monsieurtanuki
Copy link
Contributor

@teolemon Nutrition facts have a tendency to be displayed as tall tables: really not easy to fit on small screens. With a limited added-value too, as we do not extract nutrition facts from the picture.
I rather recommend something like a "add picture" or "see picture" button on top, that would lead to the "official" image edit page:
Screenshot_2023-03-17-12-04-20

@teolemon
Copy link
Member Author

teolemon commented Mar 17, 2023

Sounds good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

2 participants