Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We can add Robotoff questions filtered on category in the category editing section #3985

Open
Tracked by #4027 ...
teolemon opened this issue May 19, 2023 · 9 comments
Labels
✏️ Editing Many products are incomplete and don't have Nutri-Score, Eco-Score…so editing is important for users 🎯 P1 🤖 Robotoff

Comments

@teolemon
Copy link
Member

teolemon commented May 19, 2023

What

Part of

@monsieurtanuki
Copy link
Contributor

@teolemon Why not, but there should be the corresponding off-dart issues first.
Could you say precisely which query you're referring to: Fetch questions with insight_types? In that case there's no barcode. I don't understand everything there.

@teolemon
Copy link
Member Author

teolemon commented Jun 6, 2023

@monsieurtanuki
Copy link
Contributor

@teolemon Fair enough, we can already use InsightType.
But:

  • if it's for getRandomQuestions, its server side ('api/v1/questions/random') is deprecated
  • if it's for a given barcode (getProductQuestions), there's no InsightType parameter
  • if it's for random insight (getRandomInsights), we currently do not use this off-dart method. And I cannot picture what the UX would be. Something like "You're very good with food categories? Then help us!"

@teolemon
Copy link
Member Author

teolemon commented Jun 6, 2023

Something along those lines @monsieurtanuki ?
image
Do we fill the field with the value (with possibly a green save effect to make it clear that the answer has already been sent using Robotoff) if the question is answered ?

@teolemon
Copy link
Member Author

teolemon commented Jun 6, 2023

And possibly likeso for labels

image

@monsieurtanuki
Copy link
Contributor

@teolemon I understand your UI, but no methods we have in off-dart have both the barcode and the insight type...

@teolemon
Copy link
Member Author

teolemon commented Jun 6, 2023

noted, I'm heading home, will try to open the matching issues @monsieurtanuki

@teolemon
Copy link
Member Author

teolemon commented Jun 7, 2023

Opened

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✏️ Editing Many products are incomplete and don't have Nutri-Score, Eco-Score…so editing is important for users 🎯 P1 🤖 Robotoff
Projects
Status: 💬 To discuss and validate
Development

No branches or pull requests

2 participants