Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not make knowledge panels tappable if they contain only a title and no elements #5700

Closed
stephanegigandet opened this issue Oct 16, 2024 · 0 comments · Fixed by #5709
Closed
Assignees

Comments

@stephanegigandet
Copy link
Contributor

We are going to display a list of ingredients with 1 knowledge panel for each ingredient. In a lot of cases, the panel will just be a title like "Sugar: 50%", and there won't be any content. In that case, we want to display the title, but without an arrow to the right, and without an option to tap it.

It will look something like that:

Image

Here only the corn syrup has extra content and is expandable / tappable.

Currently on the app, panels with no content elements are tappable:

Image

So if a panel has no "elements" or the size of the "elements" is 0, it should just display the element title.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

3 participants