feat: 5621 - "road to scores" label now depends on OxF #5772
+20
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Impacted files: * `app_en.arb`: added labels for OxF versions * `product_incomplete_card.dart`: button label depends on OxF * `product_query.dart`: new `getRoadToScoreLabel` method
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #5772 +/- ##
==========================================
- Coverage 9.54% 7.05% -2.49%
==========================================
Files 325 409 +84
Lines 16411 21969 +5558
==========================================
- Hits 1567 1551 -16
- Misses 14844 20418 +5574 ☔ View full report in Codecov by Sentry. |
teolemon
added
the
🛣️ Road to scores
|
Thank you @teolemon for your review! Typically not an easy issue to test as it would be very simple to create a dumb product from scratch in test env, and wait until the message appears. We cannot do that because there's no beauty test env and searching on that server (in order not to find the product) causes an error. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fixes bug(s)
Impacted files
app_en.arb: added labels for OxF versionsproduct_incomplete_card.dart: button label depends on OxFproduct_query.dart: newgetRoadToScoreLabelmethod