Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Image gallery language not selectable (+ too long AppBar title #5968

Merged
merged 3 commits into from
Nov 30, 2024

Conversation

g123k
Copy link
Collaborator

@g123k g123k commented Nov 29, 2024

Hi everyone!

This PR fixes two issues:

  • We can't select a new language in the gallery
  • When there is a subtitle, the AppBar continues to take 2 lines

🎥 Video: https://github.com/user-attachments/assets/a5ef22ff-6061-4181-99fc-a6eba040c6e8

One important thing: to prevent complex code and potential bugs, if a language is added from the "Details" view, it will only appear once uploaded (adding a language from this screen is a minor case, so I prefer to keep a maintainable code).

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 4.76190% with 20 lines in your changes missing coverage. Please review.

Project coverage is 6.53%. Comparing base (4d9c7fc) to head (b82653e).
Report is 539 commits behind head on develop.

Files with missing lines Patch % Lines
...oduct/gallery_view/product_image_gallery_tabs.dart 0.00% 20 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           develop   #5968      +/-   ##
==========================================
- Coverage     9.54%   6.53%   -3.02%     
==========================================
  Files          325     440     +115     
  Lines        16411   24856    +8445     
==========================================
+ Hits          1567    1624      +57     
- Misses       14844   23232    +8388     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@teolemon teolemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great @g123k , I have an IKEA food with 20 languages waiting for addition 🙃

@teolemon teolemon merged commit 47b6ee3 into openfoodfacts:develop Nov 30, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Cropped title in images selection page Language addition is not working in the photo manager
3 participants