Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a deep link to the website at the bottom of the Product page for editing the product. #674

Closed
1 task
Tracked by #655
monsieurtanuki opened this issue Nov 18, 2021 · 14 comments
Labels
✏️ Contribution ✏️ Editing Many products are incomplete and don't have Nutri-Score, Eco-Score…so editing is important for users help wanted Extra attention is needed 🛣️ Road to scores The easier it is to get Nutri-Score, Eco-Score, the happier the users.

Comments

@monsieurtanuki
Copy link
Contributor

monsieurtanuki commented Nov 18, 2021

What

  • Provide a deep link to the website at the bottom of the Product page for editing the product

image

Part of

@monsieurtanuki
Copy link
Contributor Author

@jasmeet0817 There's already a way to go to the website from the product page: a menu item called "website" or something like that.
The only difference is that you want instead a button or a text, at the bottom of the product page, that goes there, is that correct?

@jasmeet0817
Copy link
Contributor

Hey, actually the button itself might already be good enough, I'll ask around. The only thing is that the button (or text) should be titled something like "Edit Product details", and the link should lead directly to the contribution page on the web.

@monsieurtanuki
Copy link
Contributor Author

For the moment the "Web" menu item launches the following URL: https://openfoodfacts.org/product/${_product.barcode}/

If we want a direct access to the edit page, we should use instead something like https://world.openfoodfacts.org/cgi/product.pl?type=edit&code=3017620422003&lc=pt&cc=br, and that should probably be coded in openfoodfacts-dart, not in smoothie.

If you go directly to this page, a message says "Please sign-in to add or edit a product. If you do not yet have an account on Open Food Facts, you can register in 30 seconds." (and you cannot go to the read-only product page), which is probably not the best option, UX-wise.
Especially in two cases:

  1. you didn't expect to create an account and you're not in the mood for it right now
  2. you are already logged in on smoothie (one day that will be possible) but not on the browser, therefore you have to log in again on the browser (with the same login/password)

@M123-dev
Copy link
Member

When I remember correctly the badge on the bottom of the screen was supposed to be only be shown when the user is logged in in Smoothie and that the credentials get passed to the website so that you are already logged in. When doing it like this we would have to wait until login is implemented.

@monsieurtanuki
Copy link
Contributor Author

@M123-dev In that case it does look like we have to wait until login is implemented.

@jasmeet0817
Copy link
Contributor

Hello sorry for late reply (I'm OOO this week),

So we discussed these concerns already. This was what I remember

  1. First of all this is a stop gap solution, ideal case would be to have login implemented and even contribution via the app itself, but since we don't have contribution we want to at least give a chance to the users to update the product, even if it's a cumbersome (and annoying) one.
  2. It's ok to show this to users that aren't logged in (or don't have an account), worst case the user will exit the website but best case we will have a new user. Maybe we can indicate on the text of the link that this required login

@monsieurtanuki
Copy link
Contributor Author

@jasmeet0817 I guess it will be less cumbersome to land on the OFF read-only web product page (that has an obvious "Edit" button) than to land on a login page that has no obvious relationship with the product (except the barcode written somewhere), no access to the read-only page and no way (for the moment) to pass the login/pwd from smoothie to the web browser.

The best we can do now is to move the current feature from the menu item to a button at the bottom of the page, that goes to the read-only product page.

Once we have this button, and keeping an eye on what's going on with off-dart, we'll be able one day to add the country, the language, the login, the password and the "edit now" bool parameter.

@teolemon
Copy link
Member

I believe this day might be here.

@teolemon teolemon added ✏️ Editing Many products are incomplete and don't have Nutri-Score, Eco-Score…so editing is important for users 🛣️ Road to scores The easier it is to get Nutri-Score, Eco-Score, the happier the users. labels Dec 31, 2021
@jasmeet0817
Copy link
Contributor

@teolemon do we have mocks for how this button at the bottom of the page should look like ?

@teolemon
Copy link
Member

Yes, we have @jasmeet0817 @monsieurtanuki
image

@teolemon
Copy link
Member

There's a helper to construct the view URL in off-dart. Not sure about the edit part

@teolemon teolemon added the help wanted Extra attention is needed label Jan 22, 2022
@teolemon teolemon moved this to Todo in Road to Scores Feb 11, 2022
@teolemon
Copy link
Member

We could move it to the edit mode, and remove it once we have a fully native experience

@monsieurtanuki
Copy link
Contributor Author

We could move it to the edit mode

@teolemon That would be a good "first issue", wouldn't it?
That could be helpful for #1175 too.

@teolemon
Copy link
Member

Closing, as we now have some native editing

Repository owner moved this from Todo to Done in Road to Scores May 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✏️ Contribution ✏️ Editing Many products are incomplete and don't have Nutri-Score, Eco-Score…so editing is important for users help wanted Extra attention is needed 🛣️ Road to scores The easier it is to get Nutri-Score, Eco-Score, the happier the users.
Projects
Status: Done
Development

No branches or pull requests

4 participants