-
-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide a deep link to the website at the bottom of the Product page for editing the product. #674
Comments
@jasmeet0817 There's already a way to go to the website from the product page: a menu item called "website" or something like that. |
Hey, actually the button itself might already be good enough, I'll ask around. The only thing is that the button (or text) should be titled something like "Edit Product details", and the link should lead directly to the contribution page on the web. |
For the moment the "Web" menu item launches the following URL: If we want a direct access to the edit page, we should use instead something like If you go directly to this page, a message says "Please sign-in to add or edit a product. If you do not yet have an account on Open Food Facts, you can register in 30 seconds." (and you cannot go to the read-only product page), which is probably not the best option, UX-wise.
|
When I remember correctly the badge on the bottom of the screen was supposed to be only be shown when the user is logged in in Smoothie and that the credentials get passed to the website so that you are already logged in. When doing it like this we would have to wait until login is implemented. |
@M123-dev In that case it does look like we have to wait until login is implemented. |
Hello sorry for late reply (I'm OOO this week), So we discussed these concerns already. This was what I remember
|
@jasmeet0817 I guess it will be less cumbersome to land on the OFF read-only web product page (that has an obvious "Edit" button) than to land on a login page that has no obvious relationship with the product (except the barcode written somewhere), no access to the read-only page and no way (for the moment) to pass the login/pwd from smoothie to the web browser. The best we can do now is to move the current feature from the menu item to a button at the bottom of the page, that goes to the read-only product page. Once we have this button, and keeping an eye on what's going on with off-dart, we'll be able one day to add the country, the language, the login, the password and the "edit now" bool parameter. |
I believe this day might be here. |
@teolemon do we have mocks for how this button at the bottom of the page should look like ? |
Yes, we have @jasmeet0817 @monsieurtanuki |
There's a helper to construct the view URL in off-dart. Not sure about the edit part |
We could move it to the edit mode, and remove it once we have a fully native experience |
Closing, as we now have some native editing |
What
Part of
The text was updated successfully, but these errors were encountered: