Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: parsing error endpoint #163

Merged
merged 5 commits into from
Jan 4, 2023
Merged

feat: parsing error endpoint #163

merged 5 commits into from
Jan 4, 2023

Conversation

diivi
Copy link
Member

@diivi diivi commented Jan 3, 2023

What

  • Add an endpoint to get all parsing errors related to a project
  • Modify project list endpoint to include error_count for every project.

Fixes bug(s)

@diivi diivi changed the title feat: error parsing feat: error endpoint Jan 3, 2023
@diivi diivi changed the title feat: error endpoint feat: parsing error endpoint Jan 3, 2023
alexgarel
alexgarel reviewed Jan 3, 2023
View reviewed changes
backend/editor/entries.py Outdated Show resolved Hide resolved
@diivi @alexgarel
error_count in every project dict
43e32f5 
Co-authored-by: Alex Garel <alex@garel.org>
@diivi diivi marked this pull request as ready for review January 3, 2023 17:43
@diivi diivi requested a review from a team as a code owner January 3, 2023 17:43
alexgarel
alexgarel approved these changes Jan 4, 2023
View reviewed changes
Copy link
Member

@alexgarel alexgarel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great @diivi !

@alexgarel
Copy link
Member

@diivi merged with main, as there where conflicting changes from @aadarsh-ram

I also saw my suggestion was not correct (in fact previously list where already nested, so I kept the nesting…)

@alexgarel alexgarel merged commit 1f38d0f into openfoodfacts:main Jan 4, 2023
@alexgarel
Copy link
Member

First merged request @diivi, kudos 🎉 !

@openfoodfacts-bot openfoodfacts-bot mentioned this pull request Jan 4, 2023
Merged
@diivi diivi mentioned this pull request Jan 4, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexgarel alexgarel alexgarel approved these changes

Assignees

@diivi diivi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@diivi @alexgarel