Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: #203 added scrollbar in the table for small screen sizes #221

Merged
merged 1 commit into from
Feb 9, 2023
Merged

fix: #203 added scrollbar in the table for small screen sizes #221

merged 1 commit into from
Feb 9, 2023

Conversation

aashimawadhwa
Copy link
Contributor

@aashimawadhwa aashimawadhwa commented Feb 7, 2023 •
edited
Loading

What

  • added scrollbar in the table to make it responsive for smaller screen sizes

Screenshot

Screenshot 2023-02-08 at 2 45 40 AM (2)

Fixes bug(s)

@aashimawadhwa aashimawadhwa requested a review from a team as a code owner February 7, 2023 21:17
@aashimawadhwa
Copy link
Contributor Author

@nobeeakon @alexgarel @diivi

nobeeakon
nobeeakon approved these changes Feb 9, 2023
View reviewed changes
Copy link
Collaborator

@nobeeakon nobeeakon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!!

@nobeeakon nobeeakon merged commit 63e29d3 into openfoodfacts:main Feb 9, 2023
@openfoodfacts-bot openfoodfacts-bot mentioned this pull request Feb 9, 2023
Merged
@alexgarel
Copy link
Member

@aashimawadhwa we may have the same problem on the Material table displaying properties for an issue.

  • we would like it larger in the browser
  • but shrinking on small devices

@alexgarel
Copy link
Member

And thanks a lot for this first PR, small but accurate and very useful 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nobeeakon nobeeakon nobeeakon approved these changes

Assignees

@aashimawadhwa aashimawadhwa

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aashimawadhwa @alexgarel @nobeeakon