Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add link to the Taxonomy Editor project in PR description #472

Merged
merged 3 commits into from
Apr 10, 2024

Conversation

perierc
Copy link
Contributor

@perierc perierc commented Mar 27, 2024

What

  • On PR creation via the editor, adds a link to the Taxonomy Editor project in the PR description.
  • This introduces a FRONTEND_URL environment variable, that must be set for the link to appear correctly.

Screenshot

image

Part of

Copy link
Contributor

@eric-nguyen-cs eric-nguyen-cs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll let @alexgarel review this more in depth as it is his area of expertise

backend/editor/github_functions.py Outdated Show resolved Hide resolved
backend/editor/settings.py Outdated Show resolved Hide resolved
docker-compose.yml Show resolved Hide resolved
Copy link
Member

@alexgarel alexgarel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good @perierc, you just have to fix comments raised by @eric-nguyen-cs

backend/editor/settings.py Outdated Show resolved Hide resolved
docker-compose.yml Show resolved Hide resolved
@teolemon
Copy link
Member

are we good to merge ? @eric-nguyen-cs @perierc

@eric-nguyen-cs eric-nguyen-cs merged commit b2a7b43 into main Apr 10, 2024
7 checks passed
@eric-nguyen-cs eric-nguyen-cs deleted the perierc/add-link-to-project-in-pr branch April 10, 2024 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

QW: when we create a PR, the description should contain a link to the taxonomy editor project
4 participants