Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: New paths for API #76

Merged
merged 6 commits into from
Sep 13, 2022
Merged

feat: New paths for API #76

merged 6 commits into from
Sep 13, 2022

Conversation

aadarsh-ram
Copy link
Collaborator

@aadarsh-ram aadarsh-ram commented Sep 11, 2022

What

  • Adds GET paths for finding entry parents and children
  • Adds POST path for updating entry children
  • Adds POST paths for creation of new root node
  • Adds DELETE path for deleting a node
  • Some helper functions have also been created

Related issue(s)

Copy link
Member

@alexgarel alexgarel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aadarsh-ram kudos for your code which is correct and well organized.

I commented on some improvement that I see necessary (some are more on style).

I think we should really avoid short names like a, b etc. in our queries and use descriptive name, this really helps understand the code in a fluid way. (coming from outside, I see this more clearly as I review the code).

backend/editor/entries.py Outdated Show resolved Hide resolved
backend/editor/entries.py Outdated Show resolved Hide resolved
backend/editor/entries.py Outdated Show resolved Hide resolved
backend/editor/entries.py Outdated Show resolved Hide resolved
backend/editor/entries.py Outdated Show resolved Hide resolved
backend/editor/entries.py Outdated Show resolved Hide resolved
backend/editor/entries.py Outdated Show resolved Hide resolved
backend/editor/entries.py Outdated Show resolved Hide resolved
backend/editor/entries.py Outdated Show resolved Hide resolved
backend/editor/entries.py Outdated Show resolved Hide resolved
Copy link
Member

@alexgarel alexgarel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions to apply ! And there we are.

backend/editor/api.py Outdated Show resolved Hide resolved
backend/editor/api.py Show resolved Hide resolved
backend/editor/entries.py Outdated Show resolved Hide resolved
backend/editor/entries.py Outdated Show resolved Hide resolved
backend/editor/entries.py Outdated Show resolved Hide resolved
backend/editor/entries.py Outdated Show resolved Hide resolved
backend/editor/entries.py Outdated Show resolved Hide resolved
backend/editor/entries.py Outdated Show resolved Hide resolved
backend/editor/entries.py Outdated Show resolved Hide resolved
backend/editor/entries.py Outdated Show resolved Hide resolved
Copy link
Member

@alexgarel alexgarel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the good work.

@alexgarel alexgarel merged commit 2901cf7 into main Sep 13, 2022
@alexgarel alexgarel deleted the update-add-delete-paths branch September 13, 2022 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Paths for adding/delete nodes Paths for updating relationships of a node
2 participants