-
-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: New paths for API #76
Conversation
…facts/taxonomy-editor into update-add-delete-paths
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aadarsh-ram kudos for your code which is correct and well organized.
I commented on some improvement that I see necessary (some are more on style).
I think we should really avoid short names like a
, b
etc. in our queries and use descriptive name, this really helps understand the code in a fluid way. (coming from outside, I see this more clearly as I review the code).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some suggestions to apply ! And there we are.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the good work.
What
Related issue(s)