-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Find missing parameters in smirff99Frosst for DrugBank #216
Comments
This issue is related to #226 but I thought enumerating the generic parameters here made more sense since #226 is about the molecule set and this issue is about smirff99Frosst I apologize for the length, but I'm yet to find a concise way of writing out my thoughts on missing parameters. Based on the current MiniDrugBank set, the following types of fragments are still assigned generic parameters with smirff99Frosst. I have gotten very used to looking at SMIRKS patterns so I tried to write some that are specific enough to catch the missing chemistry. I will include some images of particularly difficult functional groups. Molecules/Fragments that caused major problemsN-P=SThis molecule had a total of 18 generic torsions around the nitrogen-phosphorous=sulfur group PeroxidesWe're missing torsions for a normal C-O-O-C peroxide, but there was a molecule with a C-N-O-O-H group and another with a H-O-O-O-C group! Trivalent, negative, sulfurThis group came up twice in the MiniDrugBank set, and even more in the full DrugBank database phosphate group with nitrogenThis is a section of molecule MiniDrugBank_167 Weird nitrile groupOddly this molecule did not come up in the torsions... so the torsion around C#N must get grouped with a generic VdwNone, which is good, there is a generic non-bond in the full DrugBank (for Helium...) BondsThere were 7 molecules with a combination of what looks like 4 missing bonds
AnglesOnly one generic angle, for the weird nitrile group
TorsionsThere are 21 molecules with generic torsions, it looks like maybe 14 different torsions? I'll try to group them below by center bond. It is possible they could be more generic than the ones I'm writing out. I also have my description of the torsion, then at least one example set of atom types in the sub bullet points Phosphorous-NitrogenBasically all of them in MiniDrugBank_180 above
Peroxides (and similar)These might all need to fall under a
Trivalent negative sulfurThere are more than one molecule with the sulfite like group in MiniDrugBank_232
|
I'm going to try to list my proposed changes for each parameter type here. It should be noted that these are the ones I thought of as "easy" to fix. Anything that is missing in the parm@Frosst world are being made into their own issues in smirff99Frosst. BONDS
ANGLE
|
Is this the full list, or something you're updating as you go? |
That is the list of Bonds and Angles, I'm still working on Torsions. Does it make more sense for me to just start a WIP pull request with everything? |
You can update the list above of proposed changes as you go, I think, and also resolve via a PR. You can open the pr whenever it makes sense to do so; I don't see a major reason to prefer opening it now or later, whichever makes the most sense in your workflow. |
Should be closed by #232 |
Since the ipython notebook for converting Frcmod files to smirff ffxml files is in this repository, I'm cross listing issue#14 from smirff99Frosst openforcefield/smirnoff99Frosst#14
The text was updated successfully, but these errors were encountered: