Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove node_modules and dist folder and add to .gitignore #16

Closed
MrMMatricks opened this issue Oct 2, 2023 · 1 comment · Fixed by #17
Closed

Remove node_modules and dist folder and add to .gitignore #16

MrMMatricks opened this issue Oct 2, 2023 · 1 comment · Fixed by #17

Comments

@MrMMatricks
Copy link

Hallo!

I was just looking into this plugin and wanted to start adding Cloudsave games. But the repo isn't set up ideally.

You should not commit the node_modules and dist folders. You should add them to the .gitignore.
Especially the node_modules folder is quite big and should not clog up the repo.

Thanks!
Matthias
@MrMMatricks MrMMatricks changed the title Add remove node_modules and dist folder and add to .gitignore Remove node_modules and dist folder and add to .gitignore Oct 2, 2023
@PaulPaulDevelops PaulPaulDevelops linked a pull request Oct 3, 2023 that will close this issue
chore/version-bumped-and-improves #17
Merged
@Ricardo385
Copy link
Collaborator

Hey @MrMMatricks thank you for your feedback! We just fixed that in our latest version v1.0.4.

Best regards,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore/version-bumped-and-improves openforge/capacitor-game-connect
2 participants
@MrMMatricks @Ricardo385