From a9b02929c15d2573fa2f710121b947d2a3fb45ec Mon Sep 17 00:00:00 2001 From: alexandre burton Date: Tue, 29 Aug 2023 20:13:05 -0400 Subject: [PATCH 1/4] update ofRandomSeed in examples and tests --- examples/3d/advanced3dExample/src/Swarm.cpp | 3 ++- examples/android/androidAdvanced3DExample/src/Swarm.cpp | 3 ++- examples/gl/billboardRotationExample/src/ofApp.cpp | 2 +- tests/addons/networkTcp/src/main.cpp | 2 +- 4 files changed, 6 insertions(+), 4 deletions(-) diff --git a/examples/3d/advanced3dExample/src/Swarm.cpp b/examples/3d/advanced3dExample/src/Swarm.cpp index 917d6447402..48b9e1af85c 100644 --- a/examples/3d/advanced3dExample/src/Swarm.cpp +++ b/examples/3d/advanced3dExample/src/Swarm.cpp @@ -17,7 +17,8 @@ void swarm::init(int nParticles, float positionDispersion, float velocityDispers particles.clear(); } - ofSeedRandom(); + // ofSeedRandom(); superfluous -- the current random engine state + // is indistinguishable from another arbirarilty-seeded state // glm::vec3 position, velocity; ofColor color; diff --git a/examples/android/androidAdvanced3DExample/src/Swarm.cpp b/examples/android/androidAdvanced3DExample/src/Swarm.cpp index a1dc5ffdce0..03e5f9d437d 100644 --- a/examples/android/androidAdvanced3DExample/src/Swarm.cpp +++ b/examples/android/androidAdvanced3DExample/src/Swarm.cpp @@ -56,7 +56,8 @@ void Swarm::init(int _nParticles, float positionDispersion, float velocityDisper // INITIALISE VALUES /////////////////////////////////////////// // - ofSeedRandom(); + // ofSeedRandom(); superfluous -- the current random engine state + // is indistinguishable from another arbirarilty-seeded state // for (int i=0; i< nParticles; i++) { diff --git a/examples/gl/billboardRotationExample/src/ofApp.cpp b/examples/gl/billboardRotationExample/src/ofApp.cpp index d3c8b426766..de3c5771865 100644 --- a/examples/gl/billboardRotationExample/src/ofApp.cpp +++ b/examples/gl/billboardRotationExample/src/ofApp.cpp @@ -52,7 +52,7 @@ void ofApp::update() { for (int i=0; i Date: Wed, 30 Aug 2023 14:46:05 -0400 Subject: [PATCH 2/4] Update Swarm.cpp -- remove ofSeedRandom --- examples/3d/advanced3dExample/src/Swarm.cpp | 3 --- 1 file changed, 3 deletions(-) diff --git a/examples/3d/advanced3dExample/src/Swarm.cpp b/examples/3d/advanced3dExample/src/Swarm.cpp index 48b9e1af85c..e9c491b82e8 100644 --- a/examples/3d/advanced3dExample/src/Swarm.cpp +++ b/examples/3d/advanced3dExample/src/Swarm.cpp @@ -17,9 +17,6 @@ void swarm::init(int nParticles, float positionDispersion, float velocityDispers particles.clear(); } - // ofSeedRandom(); superfluous -- the current random engine state - // is indistinguishable from another arbirarilty-seeded state - // glm::vec3 position, velocity; ofColor color; for(int i = 0; i < nParticles; i++){ From 767ff8dd3305886de4fd99ca0be5b93c78568e8a Mon Sep 17 00:00:00 2001 From: alexandre burton Date: Wed, 30 Aug 2023 14:48:39 -0400 Subject: [PATCH 3/4] TCP test -- remove ofSeedRandom --- tests/addons/networkTcp/src/main.cpp | 1 - 1 file changed, 1 deletion(-) diff --git a/tests/addons/networkTcp/src/main.cpp b/tests/addons/networkTcp/src/main.cpp index 2cf45053e7f..feaf5091fbd 100644 --- a/tests/addons/networkTcp/src/main.cpp +++ b/tests/addons/networkTcp/src/main.cpp @@ -257,7 +257,6 @@ class ofApp: public ofxUnitTestsApp{ } void run(){ - ofSetRandomSeed(ofGetSeconds()); // why? random engine is initialized to a non-deterministic state testNonBlocking(); testBlocking(); disconnectionAutoDetection(); From 8d3fc4339ca5d5a8bc6d3b5e857492047474bdb5 Mon Sep 17 00:00:00 2001 From: alexandre burton Date: Wed, 30 Aug 2023 14:55:35 -0400 Subject: [PATCH 4/4] Android example: remove ofSeedRandom --- examples/android/androidAdvanced3DExample/src/Swarm.cpp | 3 --- 1 file changed, 3 deletions(-) diff --git a/examples/android/androidAdvanced3DExample/src/Swarm.cpp b/examples/android/androidAdvanced3DExample/src/Swarm.cpp index 03e5f9d437d..03b8d81d25b 100644 --- a/examples/android/androidAdvanced3DExample/src/Swarm.cpp +++ b/examples/android/androidAdvanced3DExample/src/Swarm.cpp @@ -56,9 +56,6 @@ void Swarm::init(int _nParticles, float positionDispersion, float velocityDisper // INITIALISE VALUES /////////////////////////////////////////// // - // ofSeedRandom(); superfluous -- the current random engine state - // is indistinguishable from another arbirarilty-seeded state - // for (int i=0; i< nParticles; i++) { positions[i].x = (ofRandom(1.0f)-0.5f) * positionDispersion;