version of electron environment is too old. #342

2bbb · 2023-04-13T08:58:07Z

I tried to build frontend, but npm i failed with electron-prebuilt that search too old electron binary zip and not found for darwin-arm64.
and I removed it from devDependencies and build again, then it got success to build.

electron-prebuilt was marked deprecate long long year ago.
can we remove this (or replace similar one if needed)?

The text was updated successfully, but these errors were encountered:

2bbb · 2023-04-13T09:03:06Z

Error log:

2bit@2bM1Max frontend % npm i
npm WARN old lockfile
npm WARN old lockfile The npm-shrinkwrap.json file was created with an old version of npm,
npm WARN old lockfile so supplemental metadata must be fetched from the registry.
npm WARN old lockfile
npm WARN old lockfile This is a one-time fix-up, please be patient...
npm WARN old lockfile
npm WARN deprecated xmldom@0.1.31: Deprecated due to CVE-2021-21366 resolved in 0.5.0
npm WARN deprecated uuid@3.3.3: Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.
npm WARN deprecated request@2.88.0: request has been deprecated, see https://github.com/request/request/issues/3142
npm WARN deprecated ini@1.3.5: Please update to ini >=1.3.6 to avoid a prototype pollution issue
npm WARN deprecated har-validator@5.1.3: this library is no longer supported
npm WARN deprecated electron-osx-sign@0.4.17: Please use @electron/osx-sign moving forward. Be aware the API is slightly different
npm WARN deprecated asar@0.14.6: Please use @electron/asar moving forward.  There is no API change, just a package name change
npm WARN deprecated electron-download@4.1.1: Please use @electron/get moving forward.
npm WARN deprecated mkdirp@0.5.1: Legacy versions of mkdirp are no longer supported. Please update to mkdirp 1.x. (Note that the API surface has changed to use Promises in 1.x.)
npm WARN deprecated electron-download@1.4.1: Please use @electron/get moving forward.
npm notice
npm notice New major version of npm available! 8.15.1 -> 9.6.4
npm notice Changelog: https://github.com/npm/cli/releases/tag/v9.6.4
npm notice Run npm install -g npm@9.6.4 to update!
npm notice
npm ERR! code 1
npm ERR! path /Users/2bit/prog/of/openFrameworks/apps/projectGenerator/frontend/node_modules/electron-prebuilt
npm ERR! command failed
npm ERR! command sh /var/folders/yw/ttyydlp147q092m1f4lmw8_00000gn/T/postinstall-f94d572d.sh
Downloading electron-v0.30.8-darwin-arm64.zip
npm ERR! Error: GET https://github.com/atom/electron/releases/download/v0.30.8/electron-v0.30.8-darwin-arm64.zip returned 404
npm ERR! /Users/2bit/prog/of/openFrameworks/apps/projectGenerator/frontend/node_modules/electron-prebuilt/install.js:15
npm ERR!   throw err
npm ERR!   ^
npm ERR! [
npm ERR!   Error: GET https://github.com/atom/electron/releases/download/v0.30.8/electron-v0.30.8-darwin-arm64.zip returned 404
npm ERR!       at Request.<anonymous> (/Users/2bit/prog/of/openFrameworks/apps/projectGenerator/frontend/node_modules/nugget/index.js:170:61)
npm ERR!       at Request.emit (node:events:527:28)
npm ERR!       at Request.onRequestResponse (/Users/2bit/prog/of/openFrameworks/apps/projectGenerator/frontend/node_modules/request/request.js:1066:10)
npm ERR!       at ClientRequest.emit (node:events:527:28)
npm ERR!       at HTTPParser.parserOnIncomingClient [as onIncoming] (node:_http_client:631:27)
npm ERR!       at HTTPParser.parserOnHeadersComplete (node:_http_common:128:17)
npm ERR!       at TLSSocket.socketOnData (node:_http_client:494:22)
npm ERR!       at TLSSocket.emit (node:events:527:28)
npm ERR!       at addChunk (node:internal/streams/readable:315:12)
npm ERR!       at readableAddChunk (node:internal/streams/readable:289:9)
npm ERR! ]

npm ERR! A complete log of this run can be found in:
npm ERR!     /Users/2bit/.npm/_logs/2023-04-13T08_28_02_201Z-debug-0.log
2bit@2bM1Max frontend % npm update
npm WARN deprecated har-validator@5.1.5: this library is no longer supported
npm WARN deprecated electron-download@4.1.1: Please use @electron/get moving forward.
npm WARN deprecated xmldom@0.1.31: Deprecated due to CVE-2021-21366 resolved in 0.5.0
npm WARN deprecated asar@0.14.6: Please use @electron/asar moving forward.  There is no API change, just a package name change
npm WARN deprecated uuid@3.4.0: Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.
npm WARN deprecated electron-osx-sign@0.4.17: Please use @electron/osx-sign moving forward. Be aware the API is slightly different
npm WARN deprecated request@2.88.2: request has been deprecated, see https://github.com/request/request/issues/3142
npm WARN deprecated electron-download@1.4.1: Please use @electron/get moving forward.
npm ERR! code 1
npm ERR! path /Users/2bit/prog/of/openFrameworks/apps/projectGenerator/frontend/node_modules/electron-prebuilt
npm ERR! command failed
npm ERR! command sh /var/folders/yw/ttyydlp147q092m1f4lmw8_00000gn/T/postinstall-b02039c2.sh
Downloading electron-v0.30.8-darwin-arm64.zip
npm ERR! Error: GET https://github.com/atom/electron/releases/download/v0.30.8/electron-v0.30.8-darwin-arm64.zip returned 404
npm ERR! /Users/2bit/prog/of/openFrameworks/apps/projectGenerator/frontend/node_modules/electron-prebuilt/install.js:15
npm ERR!   throw err
npm ERR!   ^
npm ERR! [
npm ERR!   Error: GET https://github.com/atom/electron/releases/download/v0.30.8/electron-v0.30.8-darwin-arm64.zip returned 404
npm ERR!       at Request.<anonymous> (/Users/2bit/prog/of/openFrameworks/apps/projectGenerator/frontend/node_modules/electron-prebuilt/node_modules/nugget/index.js:170:61)
npm ERR!       at Request.emit (node:events:527:28)
npm ERR!       at Request.onRequestResponse (/Users/2bit/prog/of/openFrameworks/apps/projectGenerator/frontend/node_modules/request/request.js:1059:10)
npm ERR!       at ClientRequest.emit (node:events:527:28)
npm ERR!       at HTTPParser.parserOnIncomingClient [as onIncoming] (node:_http_client:631:27)
npm ERR!       at HTTPParser.parserOnHeadersComplete (node:_http_common:128:17)
npm ERR!       at TLSSocket.socketOnData (node:_http_client:494:22)
npm ERR!       at TLSSocket.emit (node:events:527:28)
npm ERR!       at addChunk (node:internal/streams/readable:315:12)
npm ERR!       at readableAddChunk (node:internal/streams/readable:289:9)
npm ERR! ]

dimitre · 2023-04-13T13:49:22Z

I'm also puzzled about this.
And why it doesn't run locally but works OK in github actions.

2bbb · 2023-04-13T14:26:45Z

@dimitre
maybe, intel mac is ok, and m1 doesn't have old binary...

dimitre · 2023-04-13T14:27:49Z

If you have the time submit a PR without the line, so we see how tests run

2bbb · 2023-04-13T14:33:46Z

@dimitre okay, i will post PR soon!

ofTheo · 2023-04-13T15:05:08Z

Ahh weird. I think it runs locally for me. But I’m not on a M1 Mac. The main thing though is a lot of the front end JavaScript will need a complete rewrite if we update to the latest electron. I tried it recently to fix a CI error and almost every module had a new name and approach. So it would be good to do at some point but it’s definitely not a straightforward change.

ofTheo · 2023-04-13T15:06:50Z

But if you are able to get it all working that would be amazing 🙂

2bbb · 2023-04-14T17:53:06Z

https://github.com/2bbb/projectGenerator/tree/PR/cleanup_frontend_dependencies
I pushed branch what electron-prebuilt was removed from package.json.
test was passed, but I can't judge what this is correct or not...

dimitre · 2023-04-14T17:56:47Z

Please submit a PR here.
I suggest we should test merging the PR and then reverting if something goes wrong.
The entire deployment of projectGenerator only happens on master.
If this works it will be much easier to test some deep changes I'm working on projectGenerator in this moment

ofTheo · 2023-04-14T18:03:53Z

Please don’t merge this without testing locally first. I did a similar PR recently that passed all the checks but completely broke the frontend. So definitely don’t use the checks here for testing electron changes.

ofTheo · 2023-04-14T18:17:01Z

Also running into this fyi on Intel x64.
Might be a recent change on the electron servers.

2bbb · 2023-04-15T17:45:05Z

I renamed issue title to point to the essential.

dimitre · 2023-06-25T14:54:11Z

closed by #361

ofTheo mentioned this issue Apr 15, 2023

switch electron to 0.37.8 to temp fix broken 0.30.0 #345

Merged

2bbb changed the title ~~really frontend need electron-prebuilt?~~ version of electron environment is too old. Apr 15, 2023

2bbb mentioned this issue Apr 26, 2023

update electron #361

Merged

dimitre closed this as completed Jun 25, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

version of electron environment is too old. #342

version of electron environment is too old. #342

2bbb commented Apr 13, 2023

2bbb commented Apr 13, 2023 •

edited

Loading

dimitre commented Apr 13, 2023

2bbb commented Apr 13, 2023

dimitre commented Apr 13, 2023

2bbb commented Apr 13, 2023

ofTheo commented Apr 13, 2023 via email

ofTheo commented Apr 13, 2023 via email

2bbb commented Apr 14, 2023

dimitre commented Apr 14, 2023

ofTheo commented Apr 14, 2023 via email

ofTheo commented Apr 14, 2023

2bbb commented Apr 15, 2023

dimitre commented Jun 25, 2023

version of electron environment is too old. #342

version of electron environment is too old. #342

Comments

2bbb commented Apr 13, 2023

2bbb commented Apr 13, 2023 • edited Loading

dimitre commented Apr 13, 2023

2bbb commented Apr 13, 2023

dimitre commented Apr 13, 2023

2bbb commented Apr 13, 2023

ofTheo commented Apr 13, 2023 via email

ofTheo commented Apr 13, 2023 via email

2bbb commented Apr 14, 2023

dimitre commented Apr 14, 2023

ofTheo commented Apr 14, 2023 via email

ofTheo commented Apr 14, 2023

2bbb commented Apr 15, 2023

dimitre commented Jun 25, 2023

2bbb commented Apr 13, 2023 •

edited

Loading