Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--skip-split-multis doesn't work right with ogr process on benchmark #5

Open
cholmes opened this issue Jul 26, 2023 · 1 comment
Open
Labels
bug Something isn't working conversion issues related to converting data to CNG formats google issues related to google data

Comments

@cholmes
Copy link
Collaborator

cholmes commented Jul 26, 2023

Description

Right now if you try to run --skip-split-multis on the ogr process in the benchmark command it will return a table of super fast responses. This is because the operations isn't actually running - with 'convert' it just informs that the process doesn't yet work. This is fine for convert, but for benchmark we should probably at least print a WARNING that says the times aren't valid, and maybe even just leave it off the results. Or we could run it with skip-multis, since the timing is likely representative - the difference for duckdb and pandas isn't significant. Could also just try to implement it, but I'm not sure if it's possible to do with pure command line calls.

@cholmes cholmes added the bug Something isn't working label Jul 26, 2023
@giswqs
Copy link
Member

giswqs commented Jul 26, 2023

It would be great to have some command line and Python examples that can run and reproduce issues. We can add those to the automated tests so that errors can be captured in every push.

No worries about the frequent PyPI releases. It is quite normal for a new project.

@cholmes cholmes added conversion issues related to converting data to CNG formats google issues related to google data labels Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working conversion issues related to converting data to CNG formats google issues related to google data
Projects
None yet
Development

No branches or pull requests

2 participants