Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Synchronise requirements in the metanorma asciidoc files with those in the gpq validator #218

Open
ghobona opened this issue May 17, 2024 · 1 comment

Comments

@ghobona
Copy link
Contributor

ghobona commented May 17, 2024

There is a need to synchronise requirements in the metanorma asciidoc files with those in the gpq validator.

@cholmes
Copy link
Member

cholmes commented May 17, 2024

GPQ validator checks right now are:

✓ file must include a "geo" metadata key
✓ metadata must be a JSON object
✓ metadata must include a "version" string
✓ metadata must include a "primary_column" string
✓ metadata must include a "columns" object
✓ column metadata must include the "primary_column" name
✓ column metadata must include a valid "encoding" string
✓ column metadata must include a "geometry_types" list
✓ optional "crs" must be null or a PROJJSON object
✓ optional "orientation" must be a valid string
✓ optional "edges" must be a valid string
✓ optional "bbox" must be an array of 4 or 6 numbers
✓ optional "epoch" must be a number
✓ geometry columns must not be grouped
✓ geometry columns must be stored using the BYTE_ARRAY parquet type
✓ geometry columns must be required or optional, not repeated
✓ all geometry values match the "encoding" metadata
✓ all geometry types must be included in the "geometry_types" metadata (if not empty)
✓ all polygon geometries must follow the "orientation" metadata (if present)
✓ all geometries must fall within the "bbox" metadata (if present)

So we should be sure that all of those have a 'requirement' in the asciidoc file. And also see if there's any requirements there now that should be in gpq or other validators.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants