Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate examples and test data #232

Open
tschaub opened this issue Jun 18, 2024 · 1 comment
Open

Consolidate examples and test data #232

tschaub opened this issue Jun 18, 2024 · 1 comment

Comments

@tschaub
Copy link
Collaborator

tschaub commented Jun 18, 2024

We have a single example Parquet file, a couple JSON metadata files, and an R file in the examples directory. In addition, we have a number of examples Parquet files in the test_data directory. We should consolidate these (likely remove examples and point people to test_data for examples).

All our example Parquet files should be generated by scripts in the repo. And if we need to have separate JSON metadata files, these should be generated too (though it feels like we could do without these). And after we consolidate the examples into a single location, the release process should be updated to describe how to update the examples for new versions.

@jorisvandenbossche
Copy link
Collaborator

While it would indeed be good to consolidate things, the current example.parquet is more of an actual (useful) example in the sense that it contains real-world data. While the test_data files just contains some dummy coordinates and no real attributes. So there might be some value in keeping an example file (or some) as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants