Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

specify the directory of country-EUROPE-UKMO-landsea-2023.nc in _weighted.py #99

Closed
hdelongueville opened this issue Apr 11, 2024 · 3 comments

Comments

@hdelongueville
Copy link
Contributor

hdelongueville commented Apr 11, 2024

The line 14 in [openghg_inversions/openghg_inversions/basis/algorithms/_weighted.py, branch Iss55-fix-outer-regions] should specify the whole path of country-EUROPE-UKMO-landsea-2023.nc.

For now it is:

landsea_indices = xr.open_dataset("../countries/country-EUROPE-UKMO-landsea-2023.nc")

and should be changed to:

landsea_indices = xr.open_dataset("/group/chem/acrg/LPDM/countries/country-EUROPE-UKMO-landsea-2023.nc")

to avoid error like, for example,

FileNotFoundError: [Errno 2] No such file or directory: '/user/home/qq24644/countries/country-EUROPE-UKMO-landsea-2023.nc')

@brendan-m-murphy
Copy link
Contributor

Sorry I just noticed this. To work in different settings, we probably need this to point to a path inside of openghg inversions, and have the file there (e.g. the default country file location is openghg_inversions/countries), or allow a path to be passed in.

The first option, combined with distributing the file with openghg inversions might be simplest.

@brendan-m-murphy
Copy link
Contributor

This is related to issue #56.

@brendan-m-murphy
Copy link
Contributor

It looks like this is fixed by PR #101. I'll either split that fix out or just get that PR merged in soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants