Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dlinksmarthome] Depends on Full JRE #3417

Closed
svilenvul opened this issue Mar 30, 2018 · 1 comment
Closed

[dlinksmarthome] Depends on Full JRE #3417

svilenvul opened this issue Mar 30, 2018 · 1 comment
Labels
infrastructure Build system and Karaf related issues and PRs

Comments

@svilenvul
Copy link

svilenvul commented Mar 30, 2018

Looking at the report generated by openhab/static-code-analysis#283, I see that several packages in dlinksmarthome binding depend on javax.xml.soap:

  • org.openhab.binding.dlinksmarthome.internal
  • org.openhab.binding.dlinksmarthome.internal.motionsensor

This is a violation of C.1 in the openHAB coding guidelines https://docs.openhab.org/developers/development/guidelines.html#c-language-levels-and-libraries.

It will be good if we can refactor it, so the bundle remains restricted to Compact Profile 2, or if it is not possible document that the binding is an exception.

@davidgraeff davidgraeff added the infrastructure Build system and Karaf related issues and PRs label Mar 18, 2019
@davidgraeff
Copy link
Member

Because with Java 9+ there are basically no compact profiles anymore.
Everything is added via separate libraries and with the bnd migration we are also Java 11 compatible now, so including those libraries for just those addons that need it.
Closing this now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure Build system and Karaf related issues and PRs
Projects
None yet
Development

No branches or pull requests

2 participants