Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade SpotBugs from 4.7.3 to 4.8.3 (#447) #461

Merged
merged 2 commits into from
Mar 1, 2024

Conversation

holgerfriedrich
Copy link
Member

@holgerfriedrich holgerfriedrich commented Feb 29, 2024

Refs openhab/openhab-distro#1590

This adds support for Java file version 65 (Java 21). For processing Java 21 files, we need at least to upgrade to 4.8.0 which uses newer version of ASM dependency.

Changelog:
https://github.com/spotbugs/spotbugs/blob/master/CHANGELOG.md

In addition:

  • Upgrade SpotBugs Maven plugin to 4.8.3.1.
  • Allow Java11 and Java17 compilers.

This adds support for Java file version 65 (Java 21).

Changelog:
https://github.com/spotbugs/spotbugs/blob/master/CHANGELOG.md

Upgrade SpotBugs Maven plugin to 4.8.3.1.

Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
@holgerfriedrich holgerfriedrich requested a review from a team as a code owner February 29, 2024 00:30
pom.xml Outdated Show resolved Hide resolved
Co-authored-by: Wouter Born <github@maindrain.net>
Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
Copy link
Member

@wborn wborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the upgrade!

@wborn wborn merged commit 3b50d1b into openhab:main Mar 1, 2024
3 checks passed
@wborn wborn added this to the 0.16.0 milestone Mar 1, 2024
@holgerfriedrich holgerfriedrich deleted the pr-spotbugs-48x branch March 3, 2024 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants