Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Checkstyle to 10.14.0 #463

Merged
merged 1 commit into from
Mar 24, 2024
Merged

Upgrade Checkstyle to 10.14.0 #463

merged 1 commit into from
Mar 24, 2024

Conversation

wborn
Copy link
Member

@wborn wborn commented Mar 2, 2024

Upgrades Checkstyle from 10.6.0 to 10.14.0.

For release notes, see:

https://checkstyle.sourceforge.io/releasenotes.html

@wborn
Upgrade Checkstyle to 10.14.0
bc5ae9b 
Upgrades Checkstyle from 10.6.0 to 10.14.0.

For release notes, see:

https://checkstyle.sourceforge.io/releasenotes.html

Signed-off-by: Wouter Born <github@maindrain.net>
@wborn wborn requested a review from a team as a code owner March 2, 2024 08:47
holgerfriedrich
holgerfriedrich approved these changes Mar 3, 2024
View reviewed changes
Copy link
Member

@holgerfriedrich holgerfriedrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@holgerfriedrich
Copy link
Member

I just did a comparison of 0.15.0 agains 0.16.0-SNAPSHOT (with #462 and #463) applied on openhab-core. I have removed the clutter by adding <suppress files=".+\.java" checks="TodoCommentCheck|NullAnnotationsCheck|MethodNameCheck|StaticVariableNameCheck|MemberNameCheck|LocalVariableNameCheck|PackageNameCheck|TypeNameCheck|ConstantNameCheck"/> in suppressions.xmland got the following result:
grafik

PMD seems to give more results, but for the files I checked, this is fine.

@holgerfriedrich
Copy link
Member

btw: Once we get #462 and #463, we should release.
The benefit it support for Java 21 (i.e. support for running SAT checks on class files generated with Java 21).

@holgerfriedrich holgerfriedrich mentioned this pull request Mar 3, 2024
Merged
@wborn
Copy link
Member Author

wborn commented Mar 3, 2024

That looks good! 🙂
A new release would be nice as it will also fix lots of annoying warnings (#453).

@holgerfriedrich
Copy link
Member

Hello @openhab/sat-maintainers , kindly asking to review/merge this PR. We need this as one of the last pieces towards a Java21 build. Thanks!

See comments above:

btw: Once we get #462 and #463, we should release.
The benefit it support for Java 21 (i.e. support for running SAT checks on class files generated with Java 21).

kaikreuzer
kaikreuzer approved these changes Mar 24, 2024
View reviewed changes
Copy link
Member

@kaikreuzer kaikreuzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure thing - thanks!

@kaikreuzer kaikreuzer merged commit 3f86ea6 into openhab:main Mar 24, 2024
3 checks passed
@kaikreuzer kaikreuzer added this to the 0.16.0 milestone Mar 24, 2024
@wborn wborn deleted the checkstyle-10.14.0 branch March 24, 2024 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaikreuzer kaikreuzer kaikreuzer approved these changes

@holgerfriedrich holgerfriedrich holgerfriedrich approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.16.0
Development

Successfully merging this pull request may close these issues.
3 participants
@wborn @holgerfriedrich @kaikreuzer