Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DCQL: namespace and claim_name vs path #293

Open
bc-pi opened this issue Oct 23, 2024 · 4 comments
Open

DCQL: namespace and claim_name vs path #293

bc-pi opened this issue Oct 23, 2024 · 4 comments

Comments

@bc-pi
Copy link
Member

bc-pi commented Oct 23, 2024

I still don't understand why these can't or shouldn't or aren't conveyed with path too i.e. ["org.iso.18013.5.1","first_name"] but I'll not stand in the way of progress for this PR and make a note to myself to ask/complain about it later. Or maybe just forget.

Originally posted by @bc-pi in #266 (comment) :

Screenshot 2024-10-23 at 6 41 43 AM

@markuskreusch
Copy link

I am slightly in favor of using path as the sole option to reference data inside of a credential. This will work for data of any structure, if deeply nested and complex or more simple like for mdoc where it is only a list of claims next to each other.

The semantics of how path is used would be credential format specific in this case, so the spec would define claims path pointer for JSON based credentials and a two element path array referencing namespace and claim name for mdoc
credentials. Additional credential formats would reuse path as data referencing mechanism if possible.

Having only path will keep the data objects and parsing logic more simple and defer credential specific stuff to the path evaluation logic.

@awoie
Copy link
Contributor

awoie commented Oct 24, 2024

I'm against semantic overloading of parameters depending on the credential format. That is why I'm in favor of #284 (comment).

@bc-pi
Copy link
Member Author

bc-pi commented Oct 24, 2024

From #266 (comment) @leecam said:

yeah, I still don't really like this special handling for mdocs. Its pain when implementing it too. So I guess same question from me, can everything just be paths?

@Sakurann
Copy link
Collaborator

WG discussion
also taking into account implementation experience, rough agreement to use path for both mdoc and json-based credential formats (like sd-jwt vc).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants