Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DCQL: response to multiple queries #336

Open
martijnharing opened this issue Nov 20, 2024 · 1 comment
Open

DCQL: response to multiple queries #336

martijnharing opened this issue Nov 20, 2024 · 1 comment
Labels
duplicate This issue or pull request already exists pending-close query language

Comments

@martijnharing
Copy link

martijnharing commented Nov 20, 2024

The current text for the contents of the vp_token when responding to a DCQL query says:

If DCQL was used, this is a JSON-encoded object; the keys are the id values used for the Credential Queries in the DCQL query, and the values are the Verifiable Presentations that match the respective Credential Query.

This implies that when there are two requests for the same document but each with different data elements, it's still required to respond with that document twice. For example, if the request is:
"request1": Give me document A with elements B and C
"request2": Give me document A with elements B and D

Where request1 is satisfies one use case and request2 satisfies a different one. e.g. "I want to know whether you are over 21, and optionally your address."

In this case if document A with element B,C and D is used to satisfy both of these requests, the current language seems to require to return the same document A twice in the vp_token. Once for request1 and once for request2. I assume that's not the intention, as this could for example result in needing multiple authentications, revocation checks etc while returning only a single document.

One way that this could be addressed is to remove the linking of the response to requests (e.g. have the RP do the linking). But there may also be other ways.

@Sakurann
Copy link
Collaborator

Sakurann commented Dec 5, 2024

i think this is a duplicate of #298
closing in a week, unless it is not a duplicate

@Sakurann Sakurann added pending-close duplicate This issue or pull request already exists labels Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists pending-close query language
Projects
None yet
Development

No branches or pull requests

2 participants