Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: set_conversations will create a unexpected data in database #1127

Closed
yfPanne opened this issue Sep 25, 2023 · 5 comments · Fixed by #1254
Closed

Bug: set_conversations will create a unexpected data in database #1127

yfPanne opened this issue Sep 25, 2023 · 5 comments · Fixed by #1254
Assignees
Labels
bug Categorizes issue or PR as related to a bug.

Comments

@yfPanne
Copy link

yfPanne commented Sep 25, 2023

What happened?

When i call set_conversations to set isPrivateChat setting, an unexpected data shows in database:
image
The request paramter like this:

{
  "userIDs": [
    "1685906179542224896"
  ],
  "conversation":
    {
      "conversationID": "si_1685906179542224896_1698900783803666432",
      "isPrivateChat": true
    }
}

If i set two userIDs([1685906179542224896, 1698900783803666432]), than the unexpected data will not shows.
And also, the front end receive no notification for this conversation setting changes.

I think the server what to set isPrivateChat for all users that use this conversation.
I have not test this issuefor group-conversation, but i think it may act like the same.
I think if you what that all the user use the same setting on 'isPrivateChat', that it's more easier to pass in just one user id instead of pass in all user id in the conversation.

What did you expect to happen?

  1. Setting isPrivateChat work for all user in same conversation
  2. Front end should receive the notification for this change of conversation setting

How can we reproduce it (as minimally and precisely as possible)?

Just call set_conversations with single user id, and let setting isPrivateChat change.

Anything else we need to know?

No response

version

$ {name} version
open-im-server 3.2

Cloud provider

OS version

```console # On Linux: $ cat /etc/os-release # paste output here $ uname -a # paste output here # On Windows: C:\> wmic os get Caption, Version, BuildNumber, OSArchitecture # paste output here ```

Install tools

@yfPanne yfPanne added the bug Categorizes issue or PR as related to a bug. label Sep 25, 2023
@kubbot
Copy link
Contributor

kubbot commented Nov 26, 2023

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@kubbot
Copy link
Contributor

kubbot commented Dec 4, 2023

This issue was closed because it has been stalled for 7 days with no activity.

@kubbot kubbot closed this as not planned Won't fix, can't repro, duplicate, stale Dec 4, 2023
@cubxxw
Copy link
Contributor

cubxxw commented Dec 5, 2023

@yfPanne The issue has been resolved. Thank you for your assistance.

@cubxxw
Copy link
Contributor

cubxxw commented Dec 5, 2023

/invite

@kubbot
Copy link
Contributor

kubbot commented Dec 5, 2023

We value close connections with our users, developers, and contributors here at Open-IM-Server. With a large community and maintainer team, we're always here to help and support you. Whether you're looking to join our community or have any questions or suggestions, we welcome you to get in touch with us.

Our most recommended way to get in touch is through Slack. Even if you're in China, Slack is usually not blocked by firewalls, making it an easy way to connect with us. Our Slack community is the ideal place to discuss and share ideas and suggestions with other users and developers of Open-IM-Server. You can ask technical questions, seek help, or share your experiences with other users of Open-IM-Server.

In addition to Slack, we also offer the following ways to get in touch:

  • We also have Slack channels for you to communicate and discuss. To join, visit https://slack.com/ and join our 👀 Open-IM-Server slack team channel.
  • Get in touch with us on Gmail. If you have any questions or issues that need resolving, or any suggestions and feedback for our open source projects, please feel free to contact us via email.
  • Read our blog. Our blog is a great place to stay up-to-date with Open-IM-Server projects and trends. On the blog, we share our latest developments, tech trends, and other interesting information.
  • Add Wechat and indicate that you are a user or developer of Open-IM-Server. We will process your request as soon as possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants