Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: crowsetta: A Python tool to work with any format for annotating animal vocalizations and bioacoustics data #5332

Closed
editorialbot opened this issue Apr 3, 2023 · 25 comments
Assignees
Labels
pre-review pyOpenSci Submissions associated with pyOpenSci Python TeX Track: 4 (SBCS) Social, Behavioral, and Cognitive Sciences

Comments

@editorialbot
Copy link
Collaborator

editorialbot commented Apr 3, 2023

Submitting author: @NickleDave (David Nicholson)
Repository: https://github.com/vocalpy/crowsetta
Branch with paper.md (empty if default branch): add-joss-paper
Version: 5.0.0
Editor: @oliviaguest
Reviewers: @oliviaguest
Managing EiC: Olivia Guest

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/90e3f5fadaa07b08a20266e00d2fb542"><img src="https://joss.theoj.org/papers/90e3f5fadaa07b08a20266e00d2fb542/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/90e3f5fadaa07b08a20266e00d2fb542/status.svg)](https://joss.theoj.org/papers/90e3f5fadaa07b08a20266e00d2fb542)

Author instructions

Thanks for submitting your paper to JOSS @NickleDave. Currently, there isn't a JOSS editor assigned to your paper.

The AEiC suggestion for the handling editor is @marcosvital.

@NickleDave if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission (please start at the bottom of the list).

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
@editorialbot editorialbot added pre-review Track: 4 (SBCS) Social, Behavioral, and Cognitive Sciences labels Apr 3, 2023
@editorialbot
Copy link
Collaborator Author

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.88  T=0.64 s (205.9 files/s, 22805.8 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Python                          80           1593           2913           4255
Markdown                        37           1018              0           3937
TeX                              1             34              0            428
YAML                             6             12              8            145
TOML                             1              4              0             73
JSON                             1              0              0             27
DOS Batch                        1              8              1             26
make                             1              4              6              9
reStructuredText                 3             21             84              9
XML                              1              0              0              2
-------------------------------------------------------------------------------
SUM:                           132           2694           3012           8911
-------------------------------------------------------------------------------


gitinspector failed to run statistical information for the repository

@editorialbot
Copy link
Collaborator Author

Wordcount for paper.md is 989

@editorialbot
Copy link
Collaborator Author

@astrojuanlu
Copy link

I plan to use crowsetta, so I think I could volunteer as reviewer ✋🏽

@NickleDave
Copy link

Just commenting to make sure it doesn't get missed that this was previously reviewed by pyOpenSci: pyOpenSci/software-submission#68

For a previous (recent) JOSS submission following a pyOpenSci review see #5289

@oliviaguest
Copy link
Member

@NickleDave!! Oh, so no review needed! Thanks for catching that. 🥰

@NickleDave
Copy link

Yes although I would still love @astrojuanlu to give me feedback. Just, not here 😛

@oliviaguest
Copy link
Member

@editorialbot assign @oliviaguest as editor

@editorialbot
Copy link
Collaborator Author

Assigned! @oliviaguest is now the editor

@oliviaguest
Copy link
Member

@editorialbot add @oliviaguest as reviewer

@editorialbot
Copy link
Collaborator Author

@oliviaguest added to the reviewers list!

@openjournals openjournals deleted a comment from editorialbot Apr 4, 2023
@oliviaguest
Copy link
Member

@NickleDave can you fix the PDF not compiling? Or is it not on your end, but within JOSS? 🤔

@oliviaguest
Copy link
Member

@editorialbot generate pdf

@oliviaguest
Copy link
Member

@editorialbot check references

@editorialbot
Copy link
Collaborator Author

@NickleDave
Copy link

@oliviaguest I think I fixed this error -- I left a key and a value out of the author section in the YAML. Whoops! 😬

But now that it builds I see that I actually need to fix up some of the citations and language around them in the statement of need. Sorry! 😳

I got stuck on the build error before and was hoping someone at JOSS could help me figure it out. Finally I saw it when I came back to it with fresh eyes.

Will ping you again once I fix up the citations if that's okay. Working on it now and expect to finish today or tomorrow.

@oliviaguest
Copy link
Member

@NickleDave no rush/worries! Thank you! ☺️

@NickleDave
Copy link

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@NickleDave
Copy link

ok @oliviaguest I think I have got it cleaned up now

@oliviaguest
Copy link
Member

@editorialbot check references

@oliviaguest
Copy link
Member

@editorialbot start review

@editorialbot
Copy link
Collaborator Author

OK, I've started the review over in #5338.

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1016/j.neuron.2019.09.036 is OK
- 10.3389/fnbeh.2021.811737 is OK
- 10.1111/brv.12160 is OK
- 10.1126/science.298.5598.1569 is OK
- 10.7554/eLife.67855 is OK
- 10.7554/eLife.75691 is OK
- 10.1371/journal.pone.0278522 is OK
- 10.5281/zenodo.7627197 is OK
- 10.5281/zenodo.6808839 is OK
- 10.1523/JNEUROSCI.1503-22.2022 is OK
- 10.5281/zenodo.6590205 is OK
- 10.1016/j.wocn.2018.07.001 is OK
- 10.1038/sdata.2016.18 is OK
- 10.1038/s41386-018-0303-6 is OK
- 10.1371/journal.pcbi.1008228 is OK
- 10.1038/s41467-019-11605-y is OK
- 10.7554/eLife.68837 is OK
- 10.1016/j.wocn.2018.07.001 is OK
- 10.5281/zenodo.7324324 is OK
- 10.1186/s12915-018-0494-7 is OK
- 10.1038/s41593-020-00734-z is OK
- 10.5281/zenodo.7734979 is OK
- 10.48550/arXiv.2302.10340 is OK
- 10.5281/zenodo.3509134 is OK
- 10.25080/Majora-92bf1922-00a is OK

MISSING DOIs

- 10.1097/aud.0b013e31821473f7 may be a valid DOI for title: Praat: doing phonetics by computer
- 10.3389/fninf.2018.00016 may be a valid DOI for title: Experimental Directory Structure (Exdir): An Alternative to HDF5 Without Introducing a New File Format

INVALID DOIs

- None

@csoneson csoneson added the pyOpenSci Submissions associated with pyOpenSci label Jul 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pre-review pyOpenSci Submissions associated with pyOpenSci Python TeX Track: 4 (SBCS) Social, Behavioral, and Cognitive Sciences
Projects
None yet
Development

No branches or pull requests

5 participants