-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Summit topic: Promises #86
Comments
Hey @MayaLekova thank you for opening this :) Looking forward to your workshop about promise performance! A couple of us have written user use-cases with promises in: https://github.com/nodejs/promise-use-cases and what userland libraries currently do better. Namely, after doing a community survey, going over code on GitHub and asking around and also based on my own intuition being involved with bluebird and other promise libraries for a while and answering 700 SO questions - what I saw most and intend to discuss written here is:
I don't want to suggest any actions but rather bring the issues up and discuss them and see what the people attending the workshop think about any of these. My personal feeling is that people I talked to felt the most strongly about testing async functions being hard and stack traces - but I hope to get some interesting discussion going :) |
Woah. Thanks @MayaLekova for kicking this off, and thanks @benjamingr for this nicely structured list of use cases! Looks like there's a lot to discuss for us. 👍 |
I think it's perhaps worth setting out goals for the workshop and align expectations. My personal goals for the promise workshop at the summit are:
I don't think we'll get concrete solutions or features since there is a lot of discussion to be had. I hope to learn a lot from the experience of others, meet interesting people who share a passion for making developers' debugging experience better and add a perspective on user debugging experience. |
@benjamingr That matches my expectations. We hope to develop a better understanding of the needs of developers specifically on the Node side, so that we can drive future work on V8 in the right direction. 👍 |
Being pretty new to this topic, my expectations are also around listening to what's important for the community, so we can better focus our efforts in V8. |
Hey, really nice talk @MayaLekova and @bmeurer ! Some discussion points:
|
@benjamingr ,for the @bmeurer And I want to know current Thank you. |
@JiaLiPassion Zones are a no-go for Node.js at the moment due to the error handling issues, which is sort of a shame since a lot of us are using promises now (and the issue is basically about nested callbacks). |
@JiaLiPassion that's something to discuss with @domenic and @benlesh |
Interesting discussion in the Diagnostics session about zones and async_hooks - I think the current PoV is that Node.js needs to figure out async_hooks error handling before we unblock zones. |
@benjamingr , @bmeurer , got it, thank you! |
@JiaLiPassion see the discussion in domenic/zones#9 (comment) The part that changed since 2 years ago is that async/await has risen a lot in popularity and it doesn't suffer from the same problem. Then again for async/await zones are probably less important than being to hook into just the scheduling. |
@benjamingr , yeah, currently the issue is in |
@JiaLiPassion IIRC Ben Lesh said "IE11 is saving the internet". :D This is something I plan to bring up in the second session - but TC39 is going to need to solve this for async functions and not Node.js. Feel free to open an issue in https://github.com/nodejs/promise-use-cases |
@benjamingr , got it, I will! |
Join from PC, Mac, Linux, iOS or Android: https://zoom.us/j/903800260 Or iPhone one-tap : |
@MayaLekova can you post the meeting notes :)? |
Here are the meeting notes |
@bmeurer @MayaLekova two questions:
|
I have to leave early today, but I'm happy to talk about promises in the morning. I'd say we can close this. |
Thanks for participating everything I learned a lot and I think a lot of good progress was made. Please consider filling the doodle above if you haven't already. Also pinging @BridgeAR @addaleax @littledan in case either of them would like to also participate in the follow up discussion. |
@benjamingr Apologies for my delay; I've filled out the doodle. |
The same here. |
Great, thanks for the update - going to wait for another day or two to see if anyone else wants to participate -the most likely candidate is Thu, Jul 12 @ 3:30 PM UTC unless we can figure out something that also works for @ljharb |
Creating this issue in attempt to gather links and offline discussion relevant to what's happening around the Promises topic.
Motivation:
Make promises and other asynchronous primitives competitive performance-wise to traditional callback-oriented programming and easier to trace and debug.
Events:
Resources:
// Please add whatever you feel contributes to the discussion
// Talk slides to be linked here
The text was updated successfully, but these errors were encountered: