Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

“kubectl kruise set image ”cant achieve in-place update #48

Closed
wangyx2464 opened this issue Mar 1, 2022 · 1 comment · Fixed by #49
Closed

“kubectl kruise set image ”cant achieve in-place update #48

wangyx2464 opened this issue Mar 1, 2022 · 1 comment · Fixed by #49
Assignees
@hantmac
Labels
bug Something isn't working

Comments

@wangyx2464
Copy link

当我通过set image替换镜像时不会触发原地升级，diff 一下更换镜像前后两个controllerrevision 对象中的 data 结构发现，执行了set image之后的版本丢失resource、port等配置，从而触发重建升级
@hantmac hantmac added the bug Something isn't working label Mar 5, 2022
@hantmac hantmac self-assigned this Mar 5, 2022
@hantmac
Copy link
Member

hantmac commented Mar 5, 2022

@wangyx2464 Thanks for your bug report. 已经找到问题的原因了，cloneSet 不支持 static-merge-patch, 但是 set image 误用了 merge-patch 导致全量资源更新，问题已在修复中。

@hantmac hantmac mentioned this issue Mar 5, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hantmac hantmac

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix set cmd bug caused by MergePatchType hantmac/kruise-tools
2 participants
@hantmac @wangyx2464