Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] BroadcastJob activeDeadlineSeconds did not take effect #1409

Closed
ls-2018 opened this issue Sep 9, 2023 · 1 comment
Closed

[BUG] BroadcastJob activeDeadlineSeconds did not take effect #1409

ls-2018 opened this issue Sep 9, 2023 · 1 comment
Assignees
Labels
kind/bug Something isn't working

Comments

@ls-2018
Copy link
Member

ls-2018 commented Sep 9, 2023

What happened:

pod is over 300 seconds, but still there

What you expected to happen:

pod cleared

How to reproduce it (as minimally and precisely as possible):

echo 'kind: Cluster
apiVersion: kind.x-k8s.io/v1alpha4
featureGates:
  "EphemeralContainers": true
nodes:
- role: control-plane
  image: kindest/node:v1.26.0
  extraPortMappings:
  - containerPort: 6443
    hostPort: 6443
    protocol: TCP
- role: worker
  image: kindest/node:v1.26.0
  labels:
    zone: c
' >/tmp/kind.yaml

kind create cluster --config /tmp/kind.yaml
kubectl cluster-info --context kind-kind

helm install kruise openkruise/kruise --version 1.4.0


echo 'apiVersion: apps.kruise.io/v1alpha1
kind: BroadcastJob
metadata:
  name: broadcastjob-ttl
spec:
  template:
    spec:
      containers:
        - name: pi
          image: registry.cn-hangzhou.aliyuncs.com/acejilam/tensorflow:latest-gpu     # 5.7G
      restartPolicy: OnFailure
  completionPolicy:
    type: Always
    activeDeadlineSeconds: 300
    ttlSecondsAfterFinished: 300
  paused: false
  parallelism: 3
' >/tmp/bcj.yaml
kubectl apply -f /tmp/bcj.yaml

Anything else we need to know?:

But it doesn't happen every time, and I've found that when the watch pod, node, or BroadcastJob have no events, the tuning logic doesn't fire
 

Environment:

  • Kruise version:
  • Kubernetes version (use kubectl version):
  • Install details (e.g. helm install args):
  • Others:
image image image

I changed the activeDeadlineSeconds to 30 seconds, and I did it again.

image
Copy link

stale bot commented Dec 12, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Dec 12, 2023
@stale stale bot closed this as completed Dec 20, 2023
@zmberg zmberg reopened this Dec 20, 2023
@stale stale bot removed the wontfix This will not be worked on label Dec 20, 2023
@ls-2018 ls-2018 closed this as completed Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants