Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature request] support disable pod readiness change before inplace-update #1761

Open
furykerry opened this issue Sep 26, 2024 · 1 comment
Assignees
Milestone

Comments

@furykerry
Copy link
Member

when utilizing inplace-update to implement hot-update of pod, it is not desirable to keep pod ready during inplace-update. However current cloneset and advance statefulset will enforce pod has InplaceUpdateReady readinessgate, and set the readiness gate to false before inplace-update.

What would you like to be added:

  1. make pod readiness injection setting configurable, preferably using pod lifecycle setting of cloneset and advance statefulset

Why is this needed:

@zmberg
Copy link
Member

zmberg commented Sep 26, 2024

Sort out, unify KruisePodReady , PodInplaceUpdate , lifecycle.preUpdate.markpodnotready logic

@zmberg zmberg self-assigned this Sep 26, 2024
@zmberg zmberg added this to the 1.8 milestone Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants