Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] A smaller MaxUnavailable will block the sidecarSet from updating Pods. #1832

Closed
zmberg opened this issue Nov 19, 2024 · 1 comment
Closed
Assignees
Labels
kind/bug Something isn't working

Comments

@zmberg
Copy link
Member

zmberg commented Nov 19, 2024

What happened:

apiVersion: apps.kruise.io/v1alpha1
kind: SidecarSet
metadata:
  name: test-sidecarset
spec:
  containers:
  - command:
    - sleep
    - 999d
    image: mirrors-ssl.aliyuncs.com/centos:6.8
    imagePullPolicy: IfNotPresent
    name: sidecar1
    podInjectPolicy: BeforeAppContainer
    resources: {}
    shareVolumePolicy:
      type: disabled
    terminationMessagePath: /dev/termination-log
    terminationMessagePolicy: File
    upgradeStrategy:
      upgradeType: ColdUpgrade
  injectionStrategy: {}
  revisionHistoryLimit: 10
  selector:
    matchLabels:
      app: nginx
  updateStrategy:
    maxUnavailable: 5%
    partition: 0
    type: RollingUpdate
status:
  collisionCount: 0
  latestRevision: test-sidecarset-7658c89f8d
  matchedPods: 5
  observedGeneration: 3
  readyPods: 5
  updatedPods: 0

What you expected to happen:

How to reproduce it (as minimally and precisely as possible):

Anything else we need to know?:

Environment:

  • Kruise version:
  • Kubernetes version (use kubectl version):
  • Install details (e.g. helm install args):
  • Others:
@furykerry
Copy link
Member

fixed by #1834

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants