Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature request] add more detail info. in "kubectl kruise rollout status" #964

Closed
feveee opened this issue Apr 24, 2022 · 5 comments · Fixed by openkruise/kruise-tools#65
Assignees

Comments

@feveee
Copy link

feveee commented Apr 24, 2022

kubectl kruise rollout status clonesets/pod-mv-vqqq -n testns1
Waiting for 5 pods to be ready...
Waiting for 4 pods to be ready...
Waiting for 2 pods to be ready...
Waiting for 1 pods to be ready...
CloneSet rolling update complete 5 pods at revision pod-mv-vqq

only above info. output from kruise rollout stats when run "helm upgrade"

What would you like to be added:

add podName, Pod status,CloneSet name etc. in rollout status

Why is this needed: it's helpful to monitor helm upgrade flow

@feveee
Copy link
Author

feveee commented Apr 24, 2022

updateStrategy:
maxUnavailable: 1
type: InPlaceIfPossible
inPlaceUpdateStrategy:
gracePeriodSeconds: 10
priorityStrategy:
weightPriority:
- weight: 50
matchSelector:
matchLabels:
upgrade-mode: standby
- weight: 30
matchSelector:
matchLabels:
upgrade-mode: active

we also want to check k8 logs/event about how k8 api do helm upgrade base on above strategy "weightPriority" "matchLabels"
but no detail from "kubectl logs xxx/kubectl get events"

@hantmac
Copy link
Member

hantmac commented May 22, 2022

This PR Add more detail info like this:

Waiting for 1 pods to be ready...
Updated ready pods: [sample-clone-lkvtn]
Updated not ready pods: [sample-clone-khjv5]
CloneSet sample-clone rolling update complete 2 pods at revision sample-clone-7945cb487...
Updated ready pods: [sample-clone-khjv5 sample-clone-lkvtn]
Updated not ready pods: []

@FillZpp
Copy link
Member

FillZpp commented May 23, 2022

/cc @zmberg @veophi

@FillZpp
Copy link
Member

FillZpp commented May 23, 2022

openkruise/kruise-tools#65 Add more detail info like this:

@hantmac Will it be too more pod names in the message? What's the output of kubectl rollout status?

@hantmac
Copy link
Member

hantmac commented May 23, 2022

openkruise/kruise-tools#65 Add more detail info like this:

@hantmac Will it be too more pod names in the message? What's the output of kubectl rollout status?

kubectl rollout status don't show pod names in message, the output like this:

Waiting for 5 pods to be ready...
Waiting for 4 pods to be ready...
Waiting for 2 pods to be ready...
Waiting for 1 pods to be ready...
CloneSet rolling update complete 5 pods at revision pod-mv-vqq

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants