fix bug: allow optional filed maxunavilable to be nil in ads, and set default … #1007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Welcome @ABNER-1! It looks like this is your first PR to openkruise/kruise 🎉 |
ABNER-1
force-pushed
the
bugfix/allow_optional_field_in_ads
branch
2 times, most recently
from
9409636 to
83a4ffe
Compare
…value as 1 Signed-off-by: ABNER-1 <abner199709@gmail.com> Signed-off-by: yuanyuxing <yuanyuxing@bilibili.com>
ABNER-1
force-pushed
the
bugfix/allow_optional_field_in_ads
branch
from
83a4ffe to
45c8ce2
Compare
ABNER-1
changed the title
FillZpp
reviewed
Jul 15, 2022
| @@ -254,7 +254,10 @@ func unavailableCount(ds *appsv1alpha1.DaemonSet, numberToSchedule int) (int, er | |||
| } | |||
| r := ds.Spec.UpdateStrategy.RollingUpdate | |||
| if r == nil { | |||
| return 0, nil | |||
| return 1, nil | |||
There was a problem hiding this comment.
I just refer to the implementation of max surge and return the default value of maxunavilable in the doc.
Sorry to change this because I did not read all codes in ds reconcile function.
| return 1, nil | ||
| } | ||
| if r.MaxUnavailable == nil { | ||
| return 1, nil |
…mally Signed-off-by: yuanyuxing <yuanyuxing@bilibili.com>
Codecov Report
@@ Coverage Diff @@
## master #1007 +/- ##
==========================================
+ Coverage 49.10% 49.66% +0.56%
==========================================
Files 125 124 -1
Lines 12062 12090 +28
==========================================
+ Hits 5923 6005 +82
+ Misses 5235 5166 -69
- Partials 904 919 +15
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: FillZpp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
diannaowa
pushed a commit
to diannaowa/kruise
that referenced
this pull request
Sep 14, 2022
… default … (openkruise#1007) * fix bug: allow optional filed max unavilable in ads, and set default value as 1 Signed-off-by: ABNER-1 <abner199709@gmail.com> Signed-off-by: yuanyuxing <yuanyuxing@bilibili.com> * return 0 when max unavailable is nil and make the validation work normally Signed-off-by: yuanyuxing <yuanyuxing@bilibili.com> Co-authored-by: yuanyuxing <yuanyuxing@bilibili.com> Signed-off-by: Liu Zhenwei <zwliu@thoughtworks.com>
ppbits
pushed a commit
to ppbits/kruise
that referenced
this pull request
Apr 4, 2024
… default … (openkruise#1007) * fix bug: allow optional filed max unavilable in ads, and set default value as 1 * return 0 when max unavailable is nil and make the validation work normally Co-authored-by: yuanyuxing <yuanyuxing@bilibili.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix bug: allow optional filed max unavilable in ads, and set default value 1
Ⅰ. Describe what this PR does
Ⅱ. Does this pull request fix one issue?
fixes #1006
Ⅲ. Describe how to verify it
update ads with nil MaxUnavailable.
Ⅳ. Special notes for reviews