Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pod state from updating to Normal should all hooked #1022

Merged
merged 1 commit into from
Jul 14, 2022

Conversation

shiyan2016
Copy link
Member

Ⅰ. Describe what this PR does

pod state from updating to Normal should all hooked

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

@kruise-bot kruise-bot requested review from Fei-Guo and hellolijj July 14, 2022 07:54
@kruise-bot kruise-bot added the size/XS size/XS: 0-9 label Jul 14, 2022
Signed-off-by: shiyan2016 <shiyan20160606@gmail.com>
@shiyan2016 shiyan2016 force-pushed the fix/updating-to-normal branch from 5f30e67 to b3f6b1e Compare July 14, 2022 07:59
@codecov-commenter
Copy link

Codecov Report

Merging #1022 (5f30e67) into master (c29b0c1) will increase coverage by 0.02%.
The diff coverage is 50.00%.

❗ Current head 5f30e67 differs from pull request most recent head b3f6b1e. Consider uploading reports for the commit b3f6b1e to get more accurate results

@@            Coverage Diff             @@
##           master    #1022      +/-   ##
==========================================
+ Coverage   49.63%   49.66%   +0.02%     
==========================================
  Files         124      124              
  Lines       12078    12078              
==========================================
+ Hits         5995     5998       +3     
+ Misses       5167     5164       -3     
  Partials      916      916              
Flag Coverage Δ
unittests 49.66% <50.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/controller/cloneset/sync/cloneset_update.go 47.71% <0.00%> (ø)
pkg/controller/statefulset/stateful_set_control.go 61.89% <100.00%> (ø)
pkg/controller/uniteddeployment/revision.go 66.41% <0.00%> (-1.53%) ⬇️
pkg/controller/cloneset/cloneset_controller.go 54.15% <0.00%> (+1.97%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c29b0c1...b3f6b1e. Read the comment docs.

Copy link
Member

@FillZpp FillZpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kruise-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FillZpp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kruise-bot kruise-bot merged commit 2ade07a into openkruise:master Jul 14, 2022
@FillZpp FillZpp added this to the v1.3.0 milestone Jul 21, 2022
diannaowa pushed a commit to diannaowa/kruise that referenced this pull request Sep 14, 2022
Signed-off-by: shiyan2016 <shiyan20160606@gmail.com>
Signed-off-by: Liu Zhenwei <zwliu@thoughtworks.com>
ppbits pushed a commit to ppbits/kruise that referenced this pull request Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants