Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CloneSet supports to calculate scale number excluding Pods in PreparingDelete #1024

Conversation

FillZpp
Copy link
Member

@FillZpp FillZpp commented Jul 15, 2022

Signed-off-by: FillZpp FillZpp.pub@gmail.com

Ⅰ. Describe what this PR does

CloneSet supports to calculate scale number excluding Pods in PreparingDelete.

Now It provides two ways to enable it:

  1. Commandline flag --cloneset-scaling-exclude-preparing-delete which will enable for all CloneSets in the cluster.
  2. CloneSet label apps.kruise.io/cloneset-scaling-exclude-preparing-delete: "true" which will only enable for the CloneSet itself.

@kruise-bot kruise-bot requested review from Fei-Guo and hellolijj July 15, 2022 03:51
@kruise-bot kruise-bot added the size/XL size/XL: 500-999 label Jul 15, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jul 15, 2022

Codecov Report

Merging #1024 (dcf5358) into master (c29b0c1) will increase coverage by 0.14%.
The diff coverage is 64.86%.

❗ Current head dcf5358 differs from pull request most recent head 5469c11. Consider uploading reports for the commit 5469c11 to get more accurate results

@@            Coverage Diff             @@
##           master    #1024      +/-   ##
==========================================
+ Coverage   49.63%   49.78%   +0.14%     
==========================================
  Files         124      124              
  Lines       12078    12091      +13     
==========================================
+ Hits         5995     6019      +24     
+ Misses       5167     5154      -13     
- Partials      916      918       +2     
Flag Coverage Δ
unittests 49.78% <64.86%> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/controller/cloneset/sync/cloneset_scale.go 26.66% <0.00%> (+0.92%) ⬆️
...kg/controller/cloneset/sync/cloneset_sync_utils.go 89.74% <96.00%> (+2.70%) ⬆️
pkg/controller/uniteddeployment/revision.go 66.41% <0.00%> (-1.53%) ⬇️
...g/webhook/pod/validating/pod_unavailable_budget.go 64.17% <0.00%> (-0.91%) ⬇️
pkg/controller/daemonset/daemonset_util.go 57.85% <0.00%> (-0.84%) ⬇️
pkg/controller/cloneset/cloneset_event_handler.go 78.68% <0.00%> (-0.78%) ⬇️
...tentpodstate/persistent_pod_state_event_handler.go 0.00% <0.00%> (ø)
pkg/control/pubcontrol/utils.go
pkg/control/pubcontrol/pub_control_utils.go 51.78% <0.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c29b0c1...5469c11. Read the comment docs.

@FillZpp FillZpp force-pushed the cloneset-scale-up-with-preparing-delete-ignored branch from 02c6cde to a985199 Compare July 18, 2022 07:49
@FillZpp FillZpp force-pushed the cloneset-scale-up-with-preparing-delete-ignored branch from a985199 to dcf5358 Compare July 18, 2022 08:10
…ngDelete

Signed-off-by: FillZpp <FillZpp.pub@gmail.com>
@FillZpp FillZpp force-pushed the cloneset-scale-up-with-preparing-delete-ignored branch from dcf5358 to 5469c11 Compare July 18, 2022 08:12
Copy link
Member

@furykerry furykerry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@FillZpp
Copy link
Member Author

FillZpp commented Jul 18, 2022

/approve

@kruise-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FillZpp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kruise-bot kruise-bot merged commit 882f3d1 into openkruise:master Jul 18, 2022
@FillZpp FillZpp added this to the v1.3.0 milestone Jul 21, 2022
diannaowa pushed a commit to diannaowa/kruise that referenced this pull request Sep 14, 2022
…ngDelete (openkruise#1024)

Signed-off-by: FillZpp <FillZpp.pub@gmail.com>
Signed-off-by: Liu Zhenwei <zwliu@thoughtworks.com>
ppbits pushed a commit to ppbits/kruise that referenced this pull request Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants