-
Notifications
You must be signed in to change notification settings - Fork 771
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CloneSet supports to calculate scale number excluding Pods in PreparingDelete #1024
CloneSet supports to calculate scale number excluding Pods in PreparingDelete #1024
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1024 +/- ##
==========================================
+ Coverage 49.63% 49.78% +0.14%
==========================================
Files 124 124
Lines 12078 12091 +13
==========================================
+ Hits 5995 6019 +24
+ Misses 5167 5154 -13
- Partials 916 918 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
02c6cde
to
a985199
Compare
a985199
to
dcf5358
Compare
…ngDelete Signed-off-by: FillZpp <FillZpp.pub@gmail.com>
dcf5358
to
5469c11
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: FillZpp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…ngDelete (openkruise#1024) Signed-off-by: FillZpp <FillZpp.pub@gmail.com> Signed-off-by: Liu Zhenwei <zwliu@thoughtworks.com>
Signed-off-by: FillZpp FillZpp.pub@gmail.com
Ⅰ. Describe what this PR does
CloneSet supports to calculate scale number excluding Pods in PreparingDelete.
Now It provides two ways to enable it:
--cloneset-scaling-exclude-preparing-delete
which will enable for all CloneSets in the cluster.apps.kruise.io/cloneset-scaling-exclude-preparing-delete: "true"
which will only enable for the CloneSet itself.