Optimize event handler performance for PodUnavailableBudget #1027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1027 +/- ##
=======================================
Coverage 49.67% 49.67%
=======================================
Files 124 124
Lines 12088 12090 +2
=======================================
+ Hits 6005 6006 +1
- Misses 5165 5167 +2
+ Partials 918 917 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
FillZpp
force-pushed
the
optimize-code
branch
3 times, most recently
from
774f788 to
432725f
Compare
furykerry
reviewed
Jul 18, 2022
| pps := p.fetchPersistentPodState(newPod) | ||
| if pps == nil { | ||
| return | ||
| } | ||
| if !isPodValidChanged(oldPod, newPod) { |
Signed-off-by: FillZpp <FillZpp.pub@gmail.com>
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: FillZpp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
diannaowa
pushed a commit
to diannaowa/kruise
that referenced
this pull request
Sep 14, 2022
…se#1027) Signed-off-by: FillZpp <FillZpp.pub@gmail.com> Signed-off-by: Liu Zhenwei <zwliu@thoughtworks.com>
ppbits
pushed a commit
to ppbits/kruise
that referenced
this pull request
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: FillZpp FillZpp.pub@gmail.com
Ⅰ. Describe what this PR does
Optimize event handler performance for PodUnavailableBudget.