Fix go get in Makefile with go 1.18 #1036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1036 +/- ##
=======================================
Coverage 49.20% 49.20%
=======================================
Files 124 124
Lines 12259 12259
=======================================
Hits 6032 6032
Misses 5307 5307
Partials 920 920
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. |
Signed-off-by: astraw99 <wangchengiscool@gmail.com>
hantmac
approved these changes
Jul 25, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: FillZpp, hantmac The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
diannaowa
pushed a commit
to diannaowa/kruise
that referenced
this pull request
Sep 14, 2022
Signed-off-by: astraw99 <wangchengiscool@gmail.com> Signed-off-by: Liu Zhenwei <zwliu@thoughtworks.com>
ppbits
pushed a commit
to ppbits/kruise
that referenced
this pull request
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR does
From the Go 1.18 release notes, we know that the
go get -dis enabled by default,then the target package binary will not install.
So this PR fix it to work well both below or above go 1.18 by using
go installinstead ofgo get.Ⅱ. Does this pull request fix one issue?
fixes #1035
Ⅲ. Describe how to verify it
Change to defferent go version, like go 1.17 and go 1.18,
make manifestswill both work ok.Ⅳ. Special notes for reviews
Updated
kustomizeversion to make thego installwork ok on go 1.18.