Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ephemeralJob compatible with k8s version 1.20 & 1.21 #1127

Merged
merged 1 commit into from
Nov 24, 2022

Conversation

veophi
Copy link
Member

@veophi veophi commented Nov 18, 2022

Signed-off-by: mingzhou.swx mingzhou.swx@alibaba-inc.com

Ⅰ. Describe what this PR does

Make ephemeralJob compatible with k8s version 1.20 & 1.21

@kruise-bot kruise-bot added the size/L size/L: 100-499 label Nov 18, 2022
@codecov-commenter
Copy link

codecov-commenter commented Nov 18, 2022

Codecov Report

Merging #1127 (c90f714) into master (7ed4966) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1127   +/-   ##
=======================================
  Coverage   49.47%   49.47%           
=======================================
  Files         137      137           
  Lines       19326    19326           
=======================================
  Hits         9561     9561           
  Misses       8714     8714           
  Partials     1051     1051           
Flag Coverage Δ
unittests 49.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@veophi veophi force-pushed the ejob-compatiblity branch 3 times, most recently from c80128d to 9e92708 Compare November 23, 2022 07:29
import (
"context"
"encoding/json"
"fmt"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

100% of developers fix this issue

goimports: File is not goimports-ed


ℹ️ Learn about @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage
@sonatype-lift ignore Leave out the above finding from this PR
@sonatype-lift ignoreall Leave out all the existing findings from this PR
@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.


Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

Signed-off-by: mingzhou.swx <mingzhou.swx@alibaba-inc.com>
@zmberg
Copy link
Member

zmberg commented Nov 23, 2022

/lgtm

Copy link
Member

@furykerry furykerry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@furykerry
Copy link
Member

/approve

@kruise-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: furykerry

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kruise-bot kruise-bot merged commit 0cfd676 into openkruise:master Nov 24, 2022
@zmberg zmberg added this to the v1.4 milestone Feb 14, 2023
@zmberg zmberg added the kind/enhancement New feature or request label Feb 14, 2023
ppbits pushed a commit to ppbits/kruise that referenced this pull request Apr 4, 2024
…#1127)

Co-authored-by: mingzhou.swx <mingzhou.swx@alibaba-inc.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved kind/enhancement New feature or request lgtm size/L size/L: 100-499
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants