fix pod hang in PreparingUpdate state when rollback before update hook #1157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shiyan2016
force-pushed
the
fix/preparingUpdate-hang
branch
2 times, most recently
from
2d48d31 to
d0081e6
Compare
shiyan2016
changed the title
shiyan2016
force-pushed
the
fix/preparingUpdate-hang
branch
from
d0081e6 to
bf0a64c
Compare
shiyan2016
changed the title
|
/ok-to-test |
shiyan2016
force-pushed
the
fix/preparingUpdate-hang
branch
from
bf0a64c to
858b71d
Compare
|
/lgtm |
veophi
reviewed
Feb 6, 2023
| @@ -173,6 +173,13 @@ func (c *realControl) refreshPodState(cs *appsv1alpha1.CloneSet, coreControl clo | |||
| cs.Spec.Lifecycle.PreNormal == nil || | |||
| lifecycle.IsPodAllHooked(cs.Spec.Lifecycle.PreNormal, pod) { | |||
| state = appspub.LifecycleStateNormal | |||
| case appspub.LifecycleStatePreparingUpdate: | |||
| if clonesetutils.EqualToRevisionHash("", pod, updateRevision) { | |||
There was a problem hiding this comment.
plz add some annotations to explain these codes.
Signed-off-by: shiyan2016 <shiyan20160606@gmail.com>
shiyan2016
force-pushed
the
fix/preparingUpdate-hang
branch
from
858b71d to
d765df7
Compare
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zmberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR does
fix pod hang in PreparingUpdate state when rollback before update hook
Ⅱ. Does this pull request fix one issue?
fixes #1156
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews