Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature request] Change Kruise leader election from configmap to configmapsleases. #1184

Closed
zmberg opened this issue Feb 20, 2023 · 4 comments · Fixed by #1193
Closed

[feature request] Change Kruise leader election from configmap to configmapsleases. #1184

zmberg opened this issue Feb 20, 2023 · 4 comments · Fixed by #1193
Assignees
Milestone

Comments

@zmberg
Copy link
Member

zmberg commented Feb 20, 2023

What would you like to be added:

Why is this needed:

@YTGhost
Copy link
Contributor

YTGhost commented Feb 21, 2023

Maybe I can try to take over this job, can you assign this job to me?

@zmberg
Copy link
Member Author

zmberg commented Feb 22, 2023

/assign @YTGhost

@zmberg
Copy link
Member Author

zmberg commented Feb 22, 2023

@YTGhost also, you may add parameters as follows:

// leader-election-lease-duration is the duration that non-leader candidates will
// wait to force acquire leadership. This is measured against time of
// last observed ack. Default is 15 seconds.
--leader-election-lease-duration duration

// leader-election-renew-deadline is the duration that the acting controlplane will retry
// refreshing leadership before giving up. Default is 10 seconds.
--leader-election-renew-deadline duration

// leader-election-resource-lock determines which resource lock to use for leader election,
// defaults to "configmapsleases".
--leader-election-resource-lock string

// leader-election-id determines the name of the resource that leader election
// will use for holding the leader lock, Default is kruise-manager.
--leader-election-id string

// leader-election-retry-period is the duration the LeaderElector clients should wait
// between tries of actions. Default is 2 seconds.
--leader-election-retry-period duration

reference code, https://github.com/openkruise/kruise/blob/master/main.go#L86

@zmberg zmberg changed the title [feature request] Change Kruise leader election from configmap to leases. [feature request] Change Kruise leader election from configmap to configmapsleases. Feb 22, 2023
@YTGhost
Copy link
Contributor

YTGhost commented Feb 24, 2023

@zmberg I found the title was changed, it means we use configmapsleases as an intermediate step between switching from configmap to leases?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants