support attach metadata in PullImage CRI interface

[diannaowa]

Ⅰ. Describe what this PR does

Support attach metadata in PullImage CRI interface during ImagePulljobs;

apiVersion: apps.kruise.io/v1alpha1
kind: ImagePullJob
metadata:
  name: job-with-always
spec:
  image: nginx
  sandboxConfig:
    annotations:
      io.kubernetes.image.metrics.tags: "app=foo"
    labels:
      app: foo
  parallelism: 10

NodeImage:

apiVersion: apps.kruise.io/v1alpha1
kind: NodeImage
metadata:
  creationTimestamp: "2023-02-24T17:26:55Z"
  generation: 4
  labels:
    beta.kubernetes.io/arch: amd64
    beta.kubernetes.io/os: linux
    env: test-containerd
    kubernetes.io/arch: amd64
    kubernetes.io/hostname: vm-0-10-ubuntu
    kubernetes.io/os: linux
  name: vm-0-10-ubuntu
  resourceVersion: "23916206"
  uid: 8416e50e-7dd0-4cce-8d13-9425c3afd020
spec:
  images:
    nginx:
      sandboxConfig:
        annotations:
          io.kubernetes.image.metrics.tags: "app=foo"
        labels:
          app: foo
      tags:
      - createdAt: "2023-02-24T17:44:03Z"
        ownerReferences:
        - apiVersion: apps.kruise.io/v1alpha1
          kind: ImagePullJob
          name: job-with-always
          namespace: default
          uid: 64f5b96a-8596-4688-8e15-c1e7adddd209
        pullPolicy:
          backoffLimit: 3
          timeoutSeconds: 600
          ttlSecondsAfterFinished: 2246
        tag: latest
       ......

Ⅱ. Does this pull request fix one issue?

fixes #1155

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

[furykerry]

/lgtm

[furykerry]

@diannaowa plz squash multiple commits into one

[diannaowa]

@diannaowa plz squash multiple commits into one

Will do

[diannaowa]

Squash multiple commits into one.
Please review it. @furykerry

[diannaowa]

@zmberg

[zmberg]

@diannaowa Current containerd.go's PullImage function can't meet this scenarios, and i think we can use cri.go in containerd. So i suggest as follows in factory.go :

switch cfg.runtimeType {
case ContainerRuntimeDocker:
	imageService, err = runtimeimage.NewDockerImageService(cfg.runtimeURI, accountManager)
	if err != nil {
		klog.Warningf("Failed to new image service for %v (%s, %s): %v", cfg.runtimeType, cfg.runtimeURI, cfg.runtimeRemoteURI, err)
		continue
	}
case ContainerRuntimePouch:
	imageService, err = runtimeimage.NewPouchImageService(cfg.runtimeURI, accountManager)
	if err != nil {
		klog.Warningf("Failed to new image service for %v (%s, %s): %v", cfg.runtimeType, cfg.runtimeURI, cfg.runtimeRemoteURI, err)
		continue
	}
case ContainerRuntimeContainerd, ContainerRuntimeCommonCRI:
	addr, _, err := kubeletutil.GetAddressAndDialer(cfg.runtimeRemoteURI)
	if err != nil {
		klog.Warningf("Failed to get address for %v (%s, %s): %v", cfg.runtimeType, cfg.runtimeURI, cfg.runtimeRemoteURI, err)
		continue
	}
	imageService, err = runtimeimage.NewCRIImageService(addr, accountManager)
	if err != nil {
		klog.Warningf("Failed to new image service for %v (%s, %s): %v", cfg.runtimeType, cfg.runtimeURI, cfg.runtimeRemoteURI, err)
		continue
	}
}

[diannaowa]

@diannaowa Current containerd.go's PullImage function can't meet this scenarios, and i think we can use cri.go in containerd. So i suggest as follows in factory.go :

switch cfg.runtimeType {
case ContainerRuntimeDocker:
	imageService, err = runtimeimage.NewDockerImageService(cfg.runtimeURI, accountManager)
	if err != nil {
		klog.Warningf("Failed to new image service for %v (%s, %s): %v", cfg.runtimeType, cfg.runtimeURI, cfg.runtimeRemoteURI, err)
		continue
	}
case ContainerRuntimePouch:
	imageService, err = runtimeimage.NewPouchImageService(cfg.runtimeURI, accountManager)
	if err != nil {
		klog.Warningf("Failed to new image service for %v (%s, %s): %v", cfg.runtimeType, cfg.runtimeURI, cfg.runtimeRemoteURI, err)
		continue
	}
case ContainerRuntimeContainerd, ContainerRuntimeCommonCRI:
	addr, _, err := kubeletutil.GetAddressAndDialer(cfg.runtimeRemoteURI)
	if err != nil {
		klog.Warningf("Failed to get address for %v (%s, %s): %v", cfg.runtimeType, cfg.runtimeURI, cfg.runtimeRemoteURI, err)
		continue
	}
	imageService, err = runtimeimage.NewCRIImageService(addr, accountManager)
	if err != nil {
		klog.Warningf("Failed to new image service for %v (%s, %s): %v", cfg.runtimeType, cfg.runtimeURI, cfg.runtimeRemoteURI, err)
		continue
	}
}

Thanks for your review @zmberg .
That is a good idea. My thought was that after this feature was done, we would look at optimizing commonCRI and containerd, since much same behavior in during pullimge with common CRI and containerd.
If we need do this, I immediately follow this code to commit a new commit. And then the Progress of pull image will be not work when runtime is Containerd.

[zmberg]

If we need do this, I immediately follow this code to commit a new commit. And then the Progress of pull image will be not work when runtime is Containerd.

Yes, you can do this.

[diannaowa]

If we need do this, I immediately follow this code to commit a new commit. And then the Progress of pull image will be not work when runtime is Containerd.

Yes, you can do this.

Done,Please review. @zmberg

[codecov-commenter]

Codecov Report

Merging #1190 (23ff863) into master (07c51b9) will increase coverage by 0.28%.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master    #1190      +/-   ##
==========================================
+ Coverage   49.76%   50.04%   +0.28%     
==========================================
  Files         138      143       +5     
  Lines       19554    19912     +358     
==========================================
+ Hits         9731     9965     +234     
- Misses       8755     8851      +96     
- Partials     1068     1096      +28     

Flag	Coverage Δ
unittests	50.04% <ø> (+0.28%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
pkg/webhook/sidecarset/validating/utils.go	56.66% <0.00%> (-18.34%)	⬇️
...alidating/advancedcronjob_create_update_handler.go	23.57% <0.00%> (-1.06%)	⬇️
pkg/control/sidecarcontrol/util.go	53.48% <0.00%> (-0.39%)	⬇️
pkg/controller/sidecarset/sidecarset_processor.go	68.61% <0.00%> (-0.13%)	⬇️
...troller/sidecarterminator/kill_container_action.go	82.45% <0.00%> (ø)
...oller/sidecarterminator/virtual_kubelet_manager.go	75.00% <0.00%> (ø)
...troller/sidecarterminator/inplace_update_action.go	71.73% <0.00%> (ø)
...sidecarterminator/sidecar_terminator_controller.go	44.85% <0.00%> (ø)
...terminator/sidecar_terminator_pod_event_handler.go	91.04% <0.00%> (ø)
...set/validating/sidecarset_create_update_handler.go	58.92% <0.00%> (+0.62%)	⬆️
... and 1 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[zmberg]

/lgtm

[zmberg]

/approve

[kruise-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zmberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [zmberg]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment