Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update k8s registry references #1208

Merged

Conversation

asa3311
Copy link
Contributor

@asa3311 asa3311 commented Mar 8, 2023

Ⅰ. Describe what this PR does

Per kubernetes/k8s.io#4780, Kubernetes is migrating its image registry to registry.k8s.io, and this repository is impacted.

We have to update the references of k8s.gcr.io to registry.k8s.io by April 3rd to remain up-to-date.

Here's a quick search for k8s.gcr.io on this repo. [search result]. Note that there may be other valid references (like, in the form of generated code, etc) which we have to be aware of.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

Signed-off-by: xin gu <418294249@qq.com>
@kruise-bot kruise-bot requested review from Fei-Guo and furykerry March 8, 2023 03:06
@kruise-bot kruise-bot added the size/S size/S 10-29 label Mar 8, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #1208 (ca28cd9) into master (6115b9c) will not change coverage.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##           master    #1208   +/-   ##
=======================================
  Coverage   50.04%   50.04%           
=======================================
  Files         143      143           
  Lines       19906    19906           
=======================================
  Hits         9962     9962           
  Misses       8849     8849           
  Partials     1095     1095           
Flag Coverage Δ
unittests 50.04% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@furykerry furykerry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@zmberg
Copy link
Member

zmberg commented Mar 9, 2023

/approve

@kruise-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zmberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kruise-bot kruise-bot merged commit f21b91d into openkruise:master Mar 9, 2023
ppbits pushed a commit to ppbits/kruise that referenced this pull request Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants