Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use force kill strategy of CRR in sidecar terminator controller #1224

Merged
merged 1 commit into from
Mar 17, 2023

Conversation

veophi
Copy link
Member

@veophi veophi commented Mar 17, 2023

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

@veophi veophi requested a review from zmberg March 17, 2023 02:02
@kruise-bot kruise-bot requested a review from hellolijj March 17, 2023 02:02
@kruise-bot kruise-bot added the size/S size/S 10-29 label Mar 17, 2023
@zmberg zmberg added this to the v1.4 milestone Mar 17, 2023
Signed-off-by: mingzhou.swx <mingzhou.swx@alibaba-inc.com>
@veophi veophi force-pushed the sidecar-terminator-force-kill branch from 9bc95f5 to 7808bfc Compare March 17, 2023 02:42
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@eefcbb2). Click here to learn what that means.
The diff coverage is 33.33%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff            @@
##             master    #1224   +/-   ##
=========================================
  Coverage          ?   50.20%           
=========================================
  Files             ?      143           
  Lines             ?    19850           
  Branches          ?        0           
=========================================
  Hits              ?     9965           
  Misses            ?     8788           
  Partials          ?     1097           
Flag Coverage Δ
unittests 50.20% <33.33%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...troller/sidecarterminator/kill_container_action.go 82.75% <33.33%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@zmberg
Copy link
Member

zmberg commented Mar 17, 2023

/lgtm

@zmberg
Copy link
Member

zmberg commented Mar 17, 2023

/approve

@kruise-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zmberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kruise-bot kruise-bot merged commit 8204954 into openkruise:master Mar 17, 2023
diannaowa pushed a commit to diannaowa/kruise that referenced this pull request Jun 2, 2023
Signed-off-by: mingzhou.swx <mingzhou.swx@alibaba-inc.com>
Co-authored-by: mingzhou.swx <mingzhou.swx@alibaba-inc.com>
diannaowa pushed a commit to diannaowa/kruise that referenced this pull request Jun 2, 2023
Signed-off-by: mingzhou.swx <mingzhou.swx@alibaba-inc.com>
Co-authored-by: mingzhou.swx <mingzhou.swx@alibaba-inc.com>
ppbits pushed a commit to ppbits/kruise that referenced this pull request Apr 4, 2024
Co-authored-by: mingzhou.swx <mingzhou.swx@alibaba-inc.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants