Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: serviceAccountToken volume error in sidecarset #1238

Merged
merged 1 commit into from
Mar 27, 2023

Conversation

y-ykcir
Copy link
Contributor

@y-ykcir y-ykcir commented Mar 27, 2023

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

fixes #1231

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

@kruise-bot kruise-bot requested review from Fei-Guo and FillZpp March 27, 2023 05:22
@kruise-bot kruise-bot added the size/S size/S 10-29 label Mar 27, 2023
@codecov-commenter
Copy link

codecov-commenter commented Mar 27, 2023

Codecov Report

Merging #1238 (e28ef20) into master (1d1a54a) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

❗ Current head e28ef20 differs from pull request most recent head d56dd82. Consider uploading reports for the commit d56dd82 to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master    #1238      +/-   ##
==========================================
- Coverage   50.32%   50.31%   -0.02%     
==========================================
  Files         143      143              
  Lines       19846    19847       +1     
==========================================
- Hits         9988     9986       -2     
- Misses       8767     8769       +2     
- Partials     1091     1092       +1     
Flag Coverage Δ
unittests 50.31% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...set/validating/sidecarset_create_update_handler.go 59.05% <100.00%> (+0.12%) ⬆️

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Signed-off-by: ricky <yricky509@gmail.com>
@veophi
Copy link
Member

veophi commented Mar 27, 2023

/lgtm

Copy link
Member

@furykerry furykerry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kruise-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: furykerry

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kruise-bot kruise-bot merged commit fa653fe into openkruise:master Mar 27, 2023
kevin1689-cloud pushed a commit to kevin1689-cloud/kruise that referenced this pull request Apr 1, 2023
diannaowa pushed a commit to diannaowa/kruise that referenced this pull request Jun 2, 2023
diannaowa pushed a commit to diannaowa/kruise that referenced this pull request Jun 2, 2023
ppbits pushed a commit to ppbits/kruise that referenced this pull request Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] 使用sidecarset引入projected的serviceAccountToken类型的volume报错
5 participants