-
Notifications
You must be signed in to change notification settings - Fork 771
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: serviceAccountToken volume error in sidecarset #1238
Conversation
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## master #1238 +/- ##
==========================================
- Coverage 50.32% 50.31% -0.02%
==========================================
Files 143 143
Lines 19846 19847 +1
==========================================
- Hits 9988 9986 -2
- Misses 8767 8769 +2
- Partials 1091 1092 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
pkg/webhook/sidecarset/validating/sidecarset_validating_test.go
Outdated
Show resolved
Hide resolved
Signed-off-by: ricky <yricky509@gmail.com>
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: furykerry The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: ricky <yricky509@gmail.com>
Signed-off-by: ricky <yricky509@gmail.com>
Signed-off-by: ricky <yricky509@gmail.com>
Ⅰ. Describe what this PR does
Ⅱ. Does this pull request fix one issue?
fixes #1231
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews