Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the matching logic for the imagePullSecret in ImagePullJob #1241

Merged
merged 1 commit into from
Mar 30, 2023

Conversation

zmberg
Copy link
Member

@zmberg zmberg commented Mar 30, 2023

Ⅰ. Describe what this PR does

apiVersion: apps.kruise.io/v1alpha1
kind: ImagePullJob
spec:
  image: registry.private.com/app/nginx:1.9.1   # [required] image to pull
  pullSecrets:
  - app-secret

If the secret app-secret is configured as shown below, the ImagePullJob will fail to match, resulting in a failed image pull.

apiVersion: v1
data:
  .dockerconfigjson: {"auths":{"registry.private.com/app":{"username":"echoserver","password":"test","auth":"ZWNob3NlcnZlcjp0ZXN0"}}}
kind: Secret
metadata:
     name: app-secret
type: kubernetes.io/dockerconfigjson

@kruise-bot kruise-bot requested review from Fei-Guo and FillZpp March 30, 2023 09:59
@kruise-bot kruise-bot added the size/L size/L: 100-499 label Mar 30, 2023
Signed-off-by: liheng.zms <liheng.zms@alibaba-inc.com>
@zmberg zmberg force-pushed the fix-imagepulljob-secret branch from e6bdb93 to 4d7dc15 Compare March 30, 2023 10:54
@furykerry
Copy link
Member

/lgtm

@furykerry
Copy link
Member

/approve

@kruise-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: furykerry

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kruise-bot kruise-bot merged commit 8d59840 into openkruise:master Mar 30, 2023
@zmberg zmberg deleted the fix-imagepulljob-secret branch March 31, 2023 02:15
kevin1689-cloud pushed a commit to kevin1689-cloud/kruise that referenced this pull request Apr 1, 2023
diannaowa pushed a commit to diannaowa/kruise that referenced this pull request Jun 2, 2023
diannaowa pushed a commit to diannaowa/kruise that referenced this pull request Jun 2, 2023
@zmberg zmberg added this to the v1.5 milestone Jun 8, 2023
ppbits pushed a commit to ppbits/kruise that referenced this pull request Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants