Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Advanced Workload pre-download image support attach metadata in ImagePullJob #1246

Conversation

YTGhost
Copy link
Contributor

@YTGhost YTGhost commented Apr 7, 2023

Ⅰ. Describe what this PR does

Advanced Workload pre-download image support attach metadata in ImagePullJob

Ⅱ. Does this pull request fix one issue?

fixes #1240

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

@kruise-bot kruise-bot requested review from shiyan2016 and zmberg April 7, 2023 12:52
@kruise-bot kruise-bot added the size/S size/S 10-29 label Apr 7, 2023
@YTGhost YTGhost force-pushed the advanced-workload-support-attach-metadata-in-imagePullJob branch from 9aad8f7 to a013cb3 Compare April 9, 2023 10:47
@YTGhost
Copy link
Contributor Author

YTGhost commented Apr 10, 2023

@zmberg @veophi It seems that some CIs have been in a queued state. Is there any problem causing this?

… ImagePullJob

Signed-off-by: Liang Deng <283304489@qq.com>
@YTGhost YTGhost force-pushed the advanced-workload-support-attach-metadata-in-imagePullJob branch from a013cb3 to b67c8d5 Compare April 13, 2023 07:00
@codecov-commenter
Copy link

Codecov Report

Merging #1246 (b67c8d5) into master (15bf5a4) will decrease coverage by 0.03%.
The diff coverage is 13.33%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master    #1246      +/-   ##
==========================================
- Coverage   48.49%   48.47%   -0.03%     
==========================================
  Files         149      149              
  Lines       20606    20618      +12     
==========================================
+ Hits         9993     9994       +1     
- Misses       9518     9528      +10     
- Partials     1095     1096       +1     
Flag Coverage Δ
unittests 48.47% <13.33%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ontroller/daemonset/daemonset_predownload_image.go 0.00% <0.00%> (ø)
...oller/statefulset/statefulset_predownload_image.go 0.00% <0.00%> (ø)
.../controller/cloneset/cloneset_predownload_image.go 60.86% <40.00%> (-1.30%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@YTGhost
Copy link
Contributor Author

YTGhost commented Apr 13, 2023

@zmberg @veophi PTAL

@zmberg
Copy link
Member

zmberg commented Apr 15, 2023

/lgtm

@zmberg
Copy link
Member

zmberg commented Apr 15, 2023

/approve

@kruise-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zmberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kruise-bot kruise-bot merged commit 6f9961c into openkruise:master Apr 15, 2023
diannaowa pushed a commit to diannaowa/kruise that referenced this pull request Jun 2, 2023
… ImagePullJob (openkruise#1246)

Signed-off-by: Liang Deng <283304489@qq.com>
diannaowa pushed a commit to diannaowa/kruise that referenced this pull request Jun 2, 2023
… ImagePullJob (openkruise#1246)

Signed-off-by: Liang Deng <283304489@qq.com>
lilongfeng0902 pushed a commit to lilongfeng0902/kruise that referenced this pull request Sep 12, 2023
… ImagePullJob (openkruise#1246)

Signed-off-by: Liang Deng <283304489@qq.com>
ppbits pushed a commit to ppbits/kruise that referenced this pull request Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature request] Advanced Workload pre-download image support attach metadata in ImagePullJob
4 participants