Regard the pod at preparing update state as update revision when scaling #1290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1290 +/- ##
==========================================
+ Coverage 48.37% 48.54% +0.16%
==========================================
Files 151 152 +1
Lines 21178 21240 +62
==========================================
+ Hits 10245 10310 +65
+ Misses 9808 9801 -7
- Partials 1125 1129 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
veophi
force-pushed
the
preparingupdate-as-update
branch
from
9c87c81 to
7d7c865
Compare
![sonatype-lift[bot]](https://avatars.githubusercontent.com/in/9843?s=60&v=4){kind=small}
veophi
force-pushed
the
preparingupdate-as-update
branch
from
7d7c865 to
b072cb6
Compare
veophi
force-pushed
the
preparingupdate-as-update
branch
from
b072cb6 to
5a13b7f
Compare
|
/cc @shiyan2016 |
veophi
force-pushed
the
preparingupdate-as-update
branch
from
5a13b7f to
acf6058
Compare
furykerry
reviewed
Jun 19, 2023
furykerry
reviewed
Jun 19, 2023
furykerry
reviewed
Jun 19, 2023
veophi
force-pushed
the
preparingupdate-as-update
branch
from
acf6058 to
5c941c8
Compare
veophi
force-pushed
the
preparingupdate-as-update
branch
3 times, most recently
from
658646a to
36f4897
Compare
shiyan2016
reviewed
Jun 27, 2023
veophi
force-pushed
the
preparingupdate-as-update
branch
3 times, most recently
from
44a90ec to
d9a52ae
Compare
veophi
force-pushed
the
preparingupdate-as-update
branch
from
734a777 to
8968df4
Compare
veophi
changed the title
veophi
force-pushed
the
preparingupdate-as-update
branch
from
8968df4 to
8e1b1b9
Compare
|
/lgtm |
veophi
force-pushed
the
preparingupdate-as-update
branch
from
8e1b1b9 to
54fc3d6
Compare
zmberg
reviewed
Jun 28, 2023
Signed-off-by: mingzhou.swx <mingzhou.swx@alibaba-inc.com>
veophi
force-pushed
the
preparingupdate-as-update
branch
from
54fc3d6 to
22308fd
Compare
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: furykerry The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
diannaowa
pushed a commit
to diannaowa/kruise
that referenced
this pull request
Aug 29, 2023
Signed-off-by: mingzhou.swx <mingzhou.swx@alibaba-inc.com> Co-authored-by: mingzhou.swx <mingzhou.swx@alibaba-inc.com>
lilongfeng0902
pushed a commit
to lilongfeng0902/kruise
that referenced
this pull request
Sep 12, 2023
Signed-off-by: mingzhou.swx <mingzhou.swx@alibaba-inc.com> Co-authored-by: mingzhou.swx <mingzhou.swx@alibaba-inc.com>
ppbits
pushed a commit
to ppbits/kruise
that referenced
this pull request
Apr 4, 2024
Co-authored-by: mingzhou.swx <mingzhou.swx@alibaba-inc.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR does
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews