Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: modify the ginkgo.By name of pvc deletion protection e2e #1304

Conversation

kevin1689-cloud
Copy link
Contributor

Ⅰ. Describe what this PR does

In the e2e of pvc deletion protection, I notice there is a "ginkgo.By" name at here sholud be changed.
The operation at here is to delete the PVC itself, which is not "Delete the PV bounded to PVC".

Ⅱ. Does this pull request fix one issue?

None.

Ⅲ. Describe how to verify it

None.

Ⅳ. Special notes for reviews

None.

Signed-off-by: kevin1689 <kevinyang1689@163.com>
@kruise-bot kruise-bot requested review from Fei-Guo and FillZpp June 4, 2023 13:39
@kruise-bot kruise-bot added the size/XS size/XS: 0-9 label Jun 4, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #1304 (2a848e3) into master (b7977a7) will increase coverage by 0.06%.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master    #1304      +/-   ##
==========================================
+ Coverage   48.59%   48.65%   +0.06%     
==========================================
  Files         151      151              
  Lines       21042    21042              
==========================================
+ Hits        10225    10239      +14     
+ Misses       9700     9690      -10     
+ Partials     1117     1113       -4     
Flag Coverage Δ
unittests 48.65% <ø> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@furykerry
Copy link
Member

/lgtm

@furykerry
Copy link
Member

/approve

@kruise-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: furykerry

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kruise-bot kruise-bot merged commit 19240cf into openkruise:master Jun 5, 2023
@zmberg zmberg added this to the v1.5 milestone Jun 8, 2023
diannaowa pushed a commit to diannaowa/kruise that referenced this pull request Aug 29, 2023
lilongfeng0902 pushed a commit to lilongfeng0902/kruise that referenced this pull request Sep 12, 2023
ppbits pushed a commit to ppbits/kruise that referenced this pull request Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants