-
Notifications
You must be signed in to change notification settings - Fork 771
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change hot upgrade type #1335
change hot upgrade type #1335
Conversation
Sonatype Lift is retiringSonatype Lift will be retiring on Sep 12, 2023, with its analysis stopping on Aug 12, 2023. We understand that this news may come as a disappointment, and Sonatype is committed to helping you transition off it seamlessly. If you’d like to retain your data, please export your issues from the web console. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Welcome @cqnkjsx! It looks like this is your first PR to openkruise/kruise 🎉 |
} | ||
by, _ = json.Marshal(mainContainerStatuses) | ||
pod.Annotations[SidecarSetBeforeHotUpgradeStateKey] = string(by) | ||
return |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
S1023: redundant return statement
ℹ️ Expand to see all @sonatype-lift commands
You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.
Command | Usage |
---|---|
@sonatype-lift ignore |
Leave out the above finding from this PR |
@sonatype-lift ignoreall |
Leave out all the existing findings from this PR |
@sonatype-lift exclude <file|issue|path|tool> |
Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file |
Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.
Signed-off-by: jiangshixuan.jsx <jiangshixuan.jsx@alibaba-inc.com>
Signed-off-by: jiangshixuan.jsx <jiangshixuan.jsx@alibaba-inc.com>
ee70eee
to
b1c7332
Compare
@cqnkjsx: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Ⅰ. Describe what this PR does
In our specific situation, we need to hotupgrade a pod even this pod has a notready container.But when a main container converts from ready status to notready status we consider it caused by the hotupgrade process and it cannot be successfully updated.
Ⅱ. Does this pull request fix one issue?
NONE
Ⅲ. Describe how to verify it
We have added some unit tests to verify the whole process.
Ⅳ. Special notes for reviews