Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change hot upgrade type #1335

Closed
wants to merge 2 commits into from

Conversation

cqnkjsx
Copy link

@cqnkjsx cqnkjsx commented Jul 17, 2023

Ⅰ. Describe what this PR does

In our specific situation, we need to hotupgrade a pod even this pod has a notready container.But when a main container converts from ready status to notready status we consider it caused by the hotupgrade process and it cannot be successfully updated.

  1. We set it as a configurable feature. It can be enabled in config or cmd.
  2. We add judgement on whether a pod can be successfully hotupgraded.

Ⅱ. Does this pull request fix one issue?

NONE

Ⅲ. Describe how to verify it

We have added some unit tests to verify the whole process.

Ⅳ. Special notes for reviews

@kruise-bot kruise-bot requested review from furykerry and zmberg July 17, 2023 11:56
@sonatype-lift
Copy link

sonatype-lift bot commented Jul 17, 2023

Sonatype Lift is retiring

Sonatype Lift will be retiring on Sep 12, 2023, with its analysis stopping on Aug 12, 2023. We understand that this news may come as a disappointment, and Sonatype is committed to helping you transition off it seamlessly. If you’d like to retain your data, please export your issues from the web console.
We are extremely grateful and thank you for your support over the years.

📖 Read about the impacts and timeline

@kruise-bot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign zmberg for approval by writing /assign @zmberg in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kruise-bot
Copy link

Welcome @cqnkjsx! It looks like this is your first PR to openkruise/kruise 🎉

@kruise-bot kruise-bot added the size/L size/L: 100-499 label Jul 17, 2023
}
by, _ = json.Marshal(mainContainerStatuses)
pod.Annotations[SidecarSetBeforeHotUpgradeStateKey] = string(by)
return
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

S1023: redundant return statement


ℹ️ Expand to see all @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage
@sonatype-lift ignore Leave out the above finding from this PR
@sonatype-lift ignoreall Leave out all the existing findings from this PR
@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.

jiangshixuan.jsx added 2 commits July 18, 2023 09:39
Signed-off-by: jiangshixuan.jsx <jiangshixuan.jsx@alibaba-inc.com>
Signed-off-by: jiangshixuan.jsx <jiangshixuan.jsx@alibaba-inc.com>
@kruise-bot
Copy link

@cqnkjsx: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

stale bot commented Nov 7, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Nov 7, 2023
@stale stale bot closed this Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-rebase size/L size/L: 100-499 wontfix This will not be worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants