Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix EphemeralJob event handler for deleting object #1401

Merged
merged 1 commit into from
Sep 6, 2023

Conversation

FillZpp
Copy link
Member

@FillZpp FillZpp commented Sep 5, 2023

Ⅰ. Describe what this PR does

Fix EphemeralJob event handler for deleting object

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

Signed-off-by: FillZpp <FillZpp.pub@gmail.com>
@kruise-bot kruise-bot requested review from veophi and zmberg September 5, 2023 10:23
@kruise-bot kruise-bot added the size/XS size/XS: 0-9 label Sep 5, 2023
@veophi
Copy link
Member

veophi commented Sep 5, 2023

/lgtm

Copy link
Member

@furykerry furykerry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@furykerry
Copy link
Member

/approve

@kruise-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: furykerry

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kruise-bot kruise-bot merged commit ebcee23 into openkruise:master Sep 6, 2023
21 checks passed
lilongfeng0902 pushed a commit to lilongfeng0902/kruise that referenced this pull request Sep 12, 2023
Signed-off-by: FillZpp <FillZpp.pub@gmail.com>
@zmberg zmberg added this to the 1.6 milestone Mar 7, 2024
ppbits pushed a commit to ppbits/kruise that referenced this pull request Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants